Modernize code

src/kmailtransport/plugins/smtp/smtpjob.cpp

@@ -37,11 +37,7 @@ using namespace MailTransport;
 class SessionPool
 {
 public:
-    SessionPool() : ref(0)
-    {
-    }
-
-    int ref;
+    int ref = 0;
     QHash<int, KSmtp::Session *> sessions;
 
     void removeSession(KSmtp::Session *session)
@@ -74,7 +70,7 @@ public:
     {
     }
 
-    SmtpJob *q;
+    SmtpJob *const q;
     KSmtp::Session *session = nullptr;
     KSmtp::SessionUiProxy::Ptr uiProxy;
     enum State {

src/kmailtransport/plugins/transportpluginmanager.cpp

@@ -19,11 +19,6 @@ using namespace MailTransport;
 class MailTransportPluginInfo
 {
 public:
-    MailTransportPluginInfo()
-        : plugin(nullptr)
-    {
-    }
-
     QString metaDataFileNameBaseName;
     QString metaDataFileName;
     MailTransport::TransportAbstractPlugin *plugin = nullptr;

src/kmailtransport/precommandjob.cpp

@@ -26,7 +26,7 @@ public:
     PreCommandJobPrivate(PrecommandJob *parent);
     QProcess *process = nullptr;
     QString precommand;
-    PrecommandJob *q;
+    PrecommandJob *const q;
 
     // Slots
     void slotFinished(int, QProcess::ExitStatus);
@@ -35,8 +35,7 @@ public:
 };
 
 PreCommandJobPrivate::PreCommandJobPrivate(PrecommandJob *parent)
-    : process(nullptr)
-    , q(parent)
+    : q(parent)
 {
 }
 

src/kmailtransport/transportjob.cpp

@@ -16,12 +16,6 @@ using namespace MailTransport;
 class Q_DECL_HIDDEN MailTransport::TransportJob::Private
 {
 public:
-    Private()
-        : transport(nullptr)
-        , buffer(nullptr)
-    {
-    }
-
     QString sender;
     QStringList to;
     QStringList cc;

src/kmailtransport/transportmanager.cpp

@@ -68,7 +68,7 @@ public:
     int defaultTransportId;
     bool isMainInstance;
     QList<TransportJob *> walletQueue;
-    TransportManager *q = nullptr;
+    TransportManager *const q;
 
     void readConfig();
     void writeConfig();

src/kmailtransport/widgets/transportmanagementwidget.cpp

@@ -24,7 +24,7 @@ public:
     Private(TransportManagementWidget *parent);
 
     Ui::TransportManagementWidget ui;
-    TransportManagementWidget *q;
+    TransportManagementWidget *const q;
 
     // Slots
     void defaultClicked();

src/kmailtransportakonadi/filteractionjob.cpp

@@ -19,7 +19,6 @@ class Q_DECL_HIDDEN Akonadi::FilterActionJob::Private
 public:
     Private(FilterActionJob *qq)
         : q(qq)
-        , functor(nullptr)
     {
     }
 
@@ -28,7 +27,7 @@ public:
         delete functor;
     }
 
-    FilterActionJob *q;
+    FilterActionJob *const q;
     Collection collection;
     Item::List items;
     FilterAction *functor = nullptr;

src/kmailtransportakonadi/messagequeuejob.cpp

@@ -34,7 +34,6 @@ public:
     Private(MessageQueueJob *qq)
         : q(qq)
     {
-        started = false;
     }
 
     MessageQueueJob *const q;
@@ -45,7 +44,7 @@ public:
     SentBehaviourAttribute sentBehaviourAttribute;
     SentActionAttribute sentActionAttribute;
     AddressAttribute addressAttribute;
-    bool started;
+    bool started = false;
 
     /**
       Returns true if this message has everything it needs and is ready to be

src/kmailtransportakonadi/sentactionattribute.cpp

@@ -17,7 +17,6 @@ class SentActionAttribute::Action::Private : public QSharedData
 {
 public:
     Private()
-        : mType(Invalid)
     {
     }
 
@@ -28,7 +27,7 @@ public:
         mValue = other.mValue;
     }
 
-    Type mType;
+    Type mType = Invalid;
     QVariant mValue;
 };
 

src/kmailtransportakonadi/sentbehaviourattribute.cpp

@@ -13,14 +13,12 @@ class Q_DECL_HIDDEN SentBehaviourAttribute::Private
 {
 public:
     Private()
-        : mBehaviour(SentBehaviourAttribute::MoveToDefaultSentCollection)
-        , mSilent(false)
     {
     }
 
-    SentBehaviourAttribute::SentBehaviour mBehaviour;
+    SentBehaviourAttribute::SentBehaviour mBehaviour = SentBehaviourAttribute::MoveToDefaultSentCollection;
     Akonadi::Collection mMoveToCollection;
-    bool mSilent;
+    bool mSilent = false;
 };
 
 SentBehaviourAttribute::SentBehaviourAttribute(SentBehaviour beh, const Collection &moveToCollection, bool sendSilently)

src/kmailtransportakonadi/transportattribute.cpp

@@ -14,12 +14,7 @@ using namespace MailTransport;
 class Q_DECL_HIDDEN TransportAttribute::Private
 {
 public:
-    Private()
-        : mId(-1)
-    {
-    }
-
-    int mId;
+    int mId = -1;
 };
 
 TransportAttribute::TransportAttribute(int id)