Modernize code

notesagent/notesagent.cpp

@@ -20,7 +20,6 @@
 
 NotesAgent::NotesAgent(const QString &id)
     : Akonadi::AgentBase(id)
-    , mAgentInitialized(false)
 {
     Kdelibs4ConfigMigrator migrate(QStringLiteral("notesagent"));
     migrate.setConfigFiles(QStringList()

notesagent/notesagent.h

@@ -46,7 +46,7 @@ private Q_SLOTS:
     void slotStartAgent();
 
 private:
-    bool mAgentInitialized;
+    bool mAgentInitialized = false;
     NotesManager *mNotesManager = nullptr;
 };
 

notesagent/notesmanager.cpp

@@ -34,8 +34,6 @@
 
 NotesManager::NotesManager(QObject *parent)
     : QObject(parent)
-    , mListener(nullptr)
-    , mCheckAlarm(nullptr)
 {
     mSession = new Akonadi::Session("KNotes Session", this);
     mNoteRecorder = new NoteShared::NotesChangeRecorder(this);

noteshared/src/job/createnewnotejob.cpp

@@ -38,7 +38,7 @@ public:
     QString mTitle;
     QString mText;
     bool mRichText = false;
-    QWidget *mWidget = nullptr;
+    QWidget *const mWidget;
 };
 
 CreateNewNoteJob::CreateNewNoteJob(QObject *parent, QWidget *widget)

noteshared/src/network/notesnetworkreceiver.cpp

@@ -35,8 +35,7 @@ class NoteShared::NotesNetworkReceiverPrivate
 {
 public:
     NotesNetworkReceiverPrivate(QTcpSocket *s)
-        : m_timer(nullptr)
-        , m_buffer(new QByteArray())
+        : m_buffer(new QByteArray())
         , m_sock(s)
     {
     }
@@ -49,8 +48,8 @@ public:
 
     QTimer *m_timer = nullptr;       // to avoid memory and connection floods
 
-    QByteArray *m_buffer = nullptr;
-    QTcpSocket *m_sock = nullptr;
+    QByteArray *const m_buffer;
+    QTcpSocket *const m_sock;
 
     QString m_titleAddon;
 };

noteshared/src/network/notesnetworksender.h

@@ -31,7 +31,7 @@ protected Q_SLOTS:
     void slotWritten(qint64);
 
 private:
-    QTcpSocket *m_socket = nullptr;
+    QTcpSocket *const m_socket;
     QByteArray m_note;
     QByteArray m_title;
     QByteArray m_sender;

src/apps/application.cpp

@@ -13,7 +13,6 @@
 
 Application::Application(int &argc, char **argv[])
     : KontactInterface::PimUniqueApplication(argc, argv)
-    , mMainWindow(nullptr)
 {
 }
 

src/apps/knotesakonaditray.h

@@ -19,7 +19,7 @@ public:
 
 private:
     void slotGeneralPaletteChanged();
-    QIcon mIcon;
+    const QIcon mIcon;
     QColor mTextColor;
 };
 

src/notes/knote.cpp

@@ -65,11 +65,6 @@
 KNote::KNote(const QDomDocument &buildDoc, const Akonadi::Item &item, bool allowAkonadiSearchDebug, QWidget *parent)
     : QFrame(parent, Qt::FramelessWindowHint)
     , mItem(item)
-    , m_label(nullptr)
-    , m_grip(nullptr)
-    , m_button(nullptr)
-    , m_tool(nullptr)
-    , m_editor(nullptr)
     , m_kwinConf(KSharedConfig::openConfig(QStringLiteral("kwinrc")))
     , mDisplayAttribute(new KNoteDisplaySettings)
     , mAllowDebugAkonadiSearch(allowAkonadiSearchDebug)

src/print/knoteprintselectednotesdialog.cpp

@@ -23,7 +23,6 @@
 
 KNotePrintSelectedNotesDialog::KNotePrintSelectedNotesDialog(QWidget *parent)
     : QDialog(parent)
-    , mPreview(false)
 {
     setWindowTitle(i18nc("@title:window", "Select notes"));
     QVBoxLayout *mainLayout = new QVBoxLayout(this);