const'ify + modernize a little code + remove unused variable

src/aboutdata.cpp

@@ -23,7 +23,7 @@ AboutData::AboutData()
                       "Copyright © 2000–2004, 2007 Cornelius Schumacher\n"
                       "Copyright © 2004–2005 Reinhold Kainhofer\n"
                       "Copyright © 2006–2012 Allen Winter\n"
-                      "Copyright © 2012–2019 KOrganizer authors"),
+                      "Copyright © 2012–2020 KOrganizer authors"),
                  QString(),
                  QStringLiteral("https://userbase.kde.org/KOrganizer"))
 {

src/collectiongeneralpage.cpp

@@ -33,11 +33,6 @@ using namespace CalendarSupport;
 
 CollectionGeneralPage::CollectionGeneralPage(QWidget *parent)
     : CollectionPropertiesPage(parent)
-    , mBlockAlarmsCheckBox(nullptr)
-    , mNameEdit(nullptr)
-    , mIconCheckBox(nullptr)
-    , mIconButton(nullptr)
-    , mIncidencesForComboBox(nullptr)
 {
     setObjectName(QStringLiteral("CalendarSupport::CollectionGeneralPage"));
     setPageTitle(i18nc("@title:tab General settings for a folder.", "General"));

src/koeventview.cpp

@@ -26,7 +26,6 @@
 KOEventView::KOEventView(QWidget *parent)
     : KOrg::BaseView(parent)
 {
-    mReturnPressed = false;
     mTypeAhead = false;
     mTypeAheadReceiver = nullptr;
 

src/koeventview.h

@@ -152,12 +152,6 @@ private:
 
 private:
 
-    /* When we receive a QEvent with a key_Return release
-     * we will only show a new event dialog if we previously received a
-     * key_Return press, otherwise a new event dialog appears when
-     * you hit return in some yes/no dialog */
-    bool mReturnPressed;
-
     bool mTypeAhead;
     QObject *mTypeAheadReceiver = nullptr;
     QList<QEvent *> mTypeAheadEvents;

src/widgets/navigatorbar.cpp

@@ -22,7 +22,7 @@ NavigatorBar::NavigatorBar(QWidget *parent) : QWidget(parent)
     tfont.setPointSize(10);
     tfont.setBold(false);
 
-    bool isRTL = KOGlobals::self()->reverseLayout();
+    const bool isRTL = KOGlobals::self()->reverseLayout();
 
     mPrevYear = createNavigationButton(
         isRTL ? QStringLiteral("arrow-right-double") : QStringLiteral("arrow-left-double"),