Commit c4e58599 authored by Glen Ditchfield's avatar Glen Ditchfield 🐛
Browse files

Fix crash when completing a to-do in the summary view

The "Mark To-do Completed" entry in the `KUrlLabel` pop-up menu called
`completeTodo()`, which called `updateView()`, which deleted the
`KUrlLabel`.  This seems to cause a segfault in Qt.

`completeTodo()` doesn't need to call `updateView()`;
`mChanger->modifyIncidence()` will cause an update.

BUG: 454536
parent f2ceb65a
Pipeline #197420 passed with stage
in 2 minutes and 12 seconds
......@@ -307,7 +307,6 @@ void TodoSummaryWidget::completeTodo(Akonadi::Item::Id id)
KCalendarCore::Todo::Ptr oldTodo(todo->clone());
todo->setCompleted(QDateTime::currentDateTime());
(void) mChanger->modifyIncidence(todoItem, oldTodo);
updateView();
}
}
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment