1. 25 Mar, 2020 1 commit
  2. 24 Mar, 2020 1 commit
  3. 21 Mar, 2020 4 commits
  4. 26 Feb, 2020 1 commit
  5. 14 Feb, 2020 1 commit
  6. 20 Nov, 2019 1 commit
    • David Faure's avatar
      korgac: honour notification inhibition by delaying reminders · 60b10dc8
      David Faure authored
      Summary:
      Or in layman terms, don't pop up reminders during a presentation.
      
      Plasma has a "do not disturb" setting (which is even automatically
      enabled when mirroring the screen onto a projector), and that setting is
      available via a property in a freedesktop notifications interface.
      
      The code is in alarmdialog rather than alarmclient because the "suspend"
      code is in alarmdialog and calls wakeUp() directly.
      
      Test Plan:
      - Create event in korganizer with reminder in 2 minutes
      - Enable "do not disturb" mode in Plasma (Notifications systray icon)
      - Wait for > 2 minutes, no reminder
      - Disable "do not disturb" mode
      - The reminder shows immediately
      
      - Click Suspend for 1 minute
      - Enable "do not disturb" again
      - Wait for > 1 minute, no reminder
      - Disable "do not disturb" mode
      - The reminder shows immediately
      
      Reviewers: djarvie, broulik, davidedmundson
      
      Reviewed By: broulik
      
      Subscribers: winterz, kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D25399
      60b10dc8
  7. 29 Aug, 2019 1 commit
  8. 26 Aug, 2019 1 commit
  9. 24 Aug, 2019 1 commit
  10. 23 Aug, 2019 1 commit
  11. 13 Aug, 2019 1 commit
  12. 31 Jul, 2019 1 commit
  13. 30 May, 2019 1 commit
  14. 29 Mar, 2019 1 commit
  15. 21 Mar, 2019 1 commit
  16. 27 Feb, 2019 1 commit
  17. 20 Jan, 2019 1 commit
  18. 16 Jan, 2019 1 commit
    • David Fries's avatar
      korgac: Call setOnAllDesktops from showEvent · 2005a2e2
      David Fries authored
      Earlier, possibly Qt4 versions of korgac had the behavior of once the window manager flagged the window as sticky to show on all desktops, the setting would stay for the life of korgac, but with Qt5 that is cleared on every hide/show.
      
      Test Plan:
      Verify the Reminder window is flagged to show on all desktops automatically.
      
      Differential Revision: https://phabricator.kde.org/D16247
      2005a2e2
  19. 16 Nov, 2018 1 commit
  20. 29 Oct, 2018 1 commit
  21. 28 Oct, 2018 1 commit
  22. 26 Oct, 2018 3 commits
    • Laurent Montel's avatar
      Patch from David Fries · 709d5c4e
      Laurent Montel authored
      Summary
      
      Instead of saving position sometimes (application close, suspend
      reminder), save at each point the dialog hides, dismiss reminder,
      dismiss all, escape or window close, etc.
      
      In addition to saving the position, save the geometry to get the size
      as well, that way if the user wants it bigger (or smaller) the only
      have to do it once.
      
      The logic was show, move, which would run in that order, the window
      shows, then it moves to the correct location which looks bad, restore
      the position & size, then show, so it appears in the final location.
      
      BUG: 347486
      Test Plan
      
      A quicker way to test this is with a previous patch "Show Reminders" dock menu item option, as opposed to setting a bunch of reminders and waiting for them to go off.
      
      before patch is applied/after patch is applied behaviors
      
          move the Reminder window to a corner of the screen, show the Reminder window [ before/after it will appear at the same location]
          move the Reminder window to a different corner, press escape, show the Reminder window [ before the escape position didn't save and it appears in the previous location, after it appears in the escape position]
          make the Reminders window large, show Reminders window [ before/after it is the large size]
          exit korgac, run korgac, show Reminders window [ before it is back to the previous normal size, after it is the larger size]
      
      Reviewers: mlaurent, dvratil
      
      Reviewed By: dvratil
      
      Subscribers: dvratil, kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D16245
      709d5c4e
    • Laurent Montel's avatar
      Patch from David Fries · a74ddc54
      Laurent Montel authored
      The existing comment was
      
      // Try to keep the dialog small and non-obtrusive.
      but it prevented the user form making it even smaller.
      Make the minimum size smaller than the initial size, and enable
      options to take less space for it be even smaller.
      
      Reviewers: mlaurent, dvratil
      
      Reviewed By: dvratil
      
      Subscribers: dvratil, kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org//D16244
      a74ddc54
    • Laurent Montel's avatar
      korgac: Add an option to not grab keyboard focus when a reminder is displayed · 893de3dc
      Laurent Montel authored
      Summary:
      While it can make it easier to dismiss (if it grabs focus through the
      activateWindow call), it also means if you are typing and a reminder
      comes in it will both get those keystrokes and a space or return will
      dismiss the reminder before you have a chance to ever see what the
      reminder was about, which assumes you are even looking at your screen
      to see the reminder box flash up, if you are typing in a paper you
      might not even know.
      
      Test Plan:
      Setup two notifications in korganizer one minute apart.
      I the dock window menu test once with "Reminder grabs focus" enabled and once with it disabled.
      Give focus to some other program before the first alarm and second alarm, don't dismiss the reminder box between alarms.
      With "Reminder grabs focus" checked, the Reminders window should get focus on the second reminder, (this is also the behavior before this change).
      With "Reminder grabs focus" unchecked, the Reminders window should not get focus on the second reminder.
      
      Note I'm writing this up for two reminders to avoid the case of window managers which automatically give focus on every new window that pops up.  That's a policy choice on the user/window manager and if this did something to not get focus in that case, this would be going against that policy.
      
      Reviewers: mlaurent, dvratil
      
      Reviewed By: dvratil
      
      Subscribers: dvratil, kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D16242
      893de3dc
  23. 18 Oct, 2018 1 commit
  24. 09 May, 2018 1 commit
  25. 05 Apr, 2018 3 commits
  26. 30 Mar, 2018 2 commits
  27. 10 Dec, 2017 1 commit
  28. 27 Sep, 2017 1 commit
  29. 13 Sep, 2017 1 commit
  30. 12 Sep, 2017 1 commit
  31. 10 Sep, 2017 1 commit
  32. 09 Sep, 2017 1 commit