Commit c791d2f5 authored by Volker Krause's avatar Volker Krause
Browse files

Fix spelling of the Delivery Status Notification (DSN) abbreviation

parent ecd84930
Pipeline #171071 passed with stage
in 4 minutes and 21 seconds
......@@ -170,9 +170,9 @@ void SendJob::handleResponse(const ServerResponse &r)
void SendJobPrivate::sendNextRecipient()
{
const bool dnsSupport = m_session->allowsDns() ? m_dsn : false;
// qDebug() << " void SendJobPrivate::sendNextRecipient()" << m_session->allowsDns() << " dnsSupport " << dnsSupport;
q->sendCommand("RCPT TO:<" + m_recipientsCopy.takeFirst().toUtf8() + '>' + (dnsSupport ? " NOTIFY=success,failure" : ""));
const bool dsnSupport = m_session->allowsDsn() ? m_dsn : false;
// qDebug() << " void SendJobPrivate::sendNextRecipient()" << m_session->allowsDsn() << " dsnSupport " << dsnSupport;
q->sendCommand("RCPT TO:<" + m_recipientsCopy.takeFirst().toUtf8() + '>' + (dsnSupport ? " NOTIFY=success,failure" : ""));
}
void SendJobPrivate::addRecipients(const QStringList &rcpts)
......
......@@ -149,9 +149,9 @@ bool Session::allowsTls() const
return d->m_allowsTls;
}
bool Session::allowsDns() const
bool Session::allowsDsn() const
{
return d->m_allowsDns;
return d->m_allowsDsn;
}
QStringList Session::availableAuthModes() const
......@@ -259,7 +259,7 @@ void SessionPrivate::responseReceived(const ServerResponse &r)
} else if (r.text().startsWith("AUTH ")) { // krazy:exclude=strings
setAuthenticationMethods(r.text().remove(0, QByteArray("AUTH ").count()).split(' '));
} else if (r.text() == "DSN") {
m_allowsDns = true;
m_allowsDsn = true;
}
if (!r.isMultiline()) {
......
......@@ -94,9 +94,9 @@ public:
Q_REQUIRED_RESULT bool allowsTls() const;
/**
Returns true if the SMTP server has indicated that it allows DSN support, false otherwise.
Returns true if the SMTP server has indicated that it allows Delivery Status Notification (DSN) support, false otherwise.
*/
Q_REQUIRED_RESULT bool allowsDns() const;
Q_REQUIRED_RESULT bool allowsDsn() const;
/**
@todo: return parsed auth modes, instead of strings.
......
......@@ -84,7 +84,7 @@ private:
int m_size = 0;
bool m_allowsTls = false;
bool m_starttlsSent = false;
bool m_allowsDns = false;
bool m_allowsDsn = false;
QStringList m_authModes;
QString m_customHostname;
};
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment