1. 21 Mar, 2020 1 commit
    • Igor Poboiko's avatar
      [contacts] Fix ContactCreateJob with a photo · 7de9af3d
      Igor Poboiko authored
      Summary:
      When we run `ContactCreateJob`, the UID of a contact is not yet known.
      We can only add a photo only after we receive a reply from main create job.
      
      Also, since we also don't want the following race condition to trigger:
       1) Contact1 create request
       2) Contact1 reply, Photo1 change request, Contact2 create request
       3) Contact2 reply, Photo2 change request
       4) Photo1 reply (here both `currentContact` and `lastContact` is Contact2)
       5) Photo2 reply
      we only go for next contact after the previous has been fully procesed:
       1) Contact1 create request
       2) Contact1 reply, Photo1 change request
       3) Photo1 reply, Contact2 create request
       4) Contact2 reply, Photo2 change request
       5) Photo2 reply
      
      Test Plan:
      Without patch:
       1) Create a contact with photo inside KAddressBook
       2) Check Web UI: no photo is set, sometimes bunch of contacts get created (?)
      With patch:
       2) Observe a single contact with a proper photo being set
      
      Reviewers: dvratil
      
      Reviewed By: dvratil
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D28178
      7de9af3d
  2. 20 Mar, 2020 2 commits
  3. 15 Mar, 2020 2 commits
  4. 13 Mar, 2020 1 commit
  5. 12 Mar, 2020 1 commit
  6. 11 Mar, 2020 1 commit
  7. 05 Mar, 2020 1 commit
  8. 04 Mar, 2020 1 commit
  9. 26 Feb, 2020 1 commit
  10. 19 Feb, 2020 2 commits
  11. 11 Feb, 2020 1 commit
  12. 07 Feb, 2020 1 commit
  13. 01 Feb, 2020 2 commits
  14. 17 Jan, 2020 1 commit
  15. 16 Jan, 2020 1 commit
  16. 09 Jan, 2020 1 commit
  17. 03 Jan, 2020 1 commit
  18. 23 Dec, 2019 1 commit
  19. 20 Dec, 2019 1 commit
  20. 17 Dec, 2019 1 commit
  21. 12 Dec, 2019 1 commit
  22. 01 Dec, 2019 2 commits
  23. 30 Nov, 2019 1 commit
  24. 28 Nov, 2019 3 commits
  25. 25 Nov, 2019 1 commit
  26. 24 Nov, 2019 2 commits
  27. 10 Nov, 2019 1 commit
  28. 07 Nov, 2019 1 commit
  29. 23 Oct, 2019 1 commit
  30. 19 Oct, 2019 1 commit
  31. 14 Oct, 2019 1 commit
  32. 01 Oct, 2019 1 commit