1. 21 Mar, 2020 1 commit
    • Igor Poboiko's avatar
      [contacts] Fix ContactCreateJob with a photo · 7de9af3d
      Igor Poboiko authored
      Summary:
      When we run `ContactCreateJob`, the UID of a contact is not yet known.
      We can only add a photo only after we receive a reply from main create job.
      
      Also, since we also don't want the following race condition to trigger:
       1) Contact1 create request
       2) Contact1 reply, Photo1 change request, Contact2 create request
       3) Contact2 reply, Photo2 change request
       4) Photo1 reply (here both `currentContact` and `lastContact` is Contact2)
       5) Photo2 reply
      we only go for next contact after the previous has been fully procesed:
       1) Contact1 create request
       2) Contact1 reply, Photo1 change request
       3) Photo1 reply, Contact2 create request
       4) Contact2 reply, Photo2 change request
       5) Photo2 reply
      
      Test Plan:
      Without patch:
       1) Create a contact with photo inside KAddressBook
       2) Check Web UI: no photo is set, sometimes bunch of contacts get created (?)
      With patch:
       2) Observe a single contact with a proper photo being set
      
      Reviewers: dvratil
      
      Reviewed By: dvratil
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D28178
      7de9af3d
  2. 19 May, 2019 1 commit
  3. 10 Dec, 2018 1 commit
  4. 20 Jul, 2018 1 commit
  5. 25 Mar, 2018 1 commit
    • Daniel Vrátil's avatar
      Contacts: fix creating contacts with photo · 1ca63877
      Daniel Vrátil authored
      The photo upload request must be authenticated. Also properly handle the response from the
      photo upload request, so that the job does not finish before the request is actually
      dispatched.
      1ca63877
  6. 06 Jun, 2017 1 commit
  7. 03 Jun, 2017 1 commit
  8. 10 May, 2017 1 commit
  9. 15 Feb, 2017 1 commit
  10. 31 Jan, 2017 1 commit
  11. 26 Oct, 2016 1 commit
  12. 31 Aug, 2015 1 commit
  13. 27 Aug, 2015 1 commit
  14. 25 Aug, 2015 1 commit
  15. 22 Apr, 2015 1 commit
  16. 01 Jul, 2014 1 commit
  17. 03 Jun, 2014 2 commits
  18. 10 May, 2013 1 commit
    • Daniel Vrátil's avatar
      Don't skip item when restarting a job · 6605ba17
      Daniel Vrátil authored
      When a recoverable error occured (invalid tokens), the job
      skipped the item that has failed and tried to continued with
      the next one after being restarted. With single-item
      jobs this caused clients that expected exactly one item in reply
      to crash.
      
      With QueueHelper, the job will re-submit the failed item after
      restart before cnotinuing with the next in queue.
      6605ba17
  19. 27 Feb, 2013 1 commit
    • Daniel Vrátil's avatar
      LibKGAPI 2 API (breaks ABI, the old API is preserved) · 9ee82938
      Daniel Vrátil authored
      LibKGAPI2 is a new job-based API that deprecates the
      old one. It is cleaner, more flexible and much easier
      to use.
      
      The old API is still available, but all services
      internally call services from LibKGAPI2. Implementation
      of KGAPI::Objects::* classes is also shared with the
      one from LibKGAPI2 to avoid as much code duplication
      as possible. It also means that fixing serializer bug
      in LibKGAPI2 will fix it in the old API as well
      (although the old API is not officially supported as
      of now). Thanks to this, all distributions can safely
      update to LibKGAPI-2.0 without breaking any
      applications (you just need to rebuild them, because I
      had to break ABI).
      
      The old API will be removed probably after KDE 4.12 is
      released.
      
      As of now master is pointing to LibKGAPI-2.0 and there
      will be no more updates in LibKGAPI/0.4 branch.
      9ee82938