Fix clazy warning

src/ksieveui/autocreatescripts/autotests/sieveeditorgraphicalmodewidgettest.cpp

@@ -50,7 +50,7 @@ void SieveEditorGraphicalModeWidgetTest::shouldLoadScripts()
     const QString originalFile = QLatin1String(KSIEVEUI_DATA_DIR) + QLatin1Char('/') + input + QStringLiteral(".siv");
     const QString refFile = QLatin1String(KSIEVEUI_DATA_DIR) + QLatin1Char('/') + input + QStringLiteral("-ref.siv");
     const QString generatedFile = QLatin1String(KSIEVEUI_BINARY_DATA_DIR) + QLatin1Char('/') + input + QStringLiteral("-generated.siv");
-    QDir().mkpath(QLatin1String(KSIEVEUI_BINARY_DATA_DIR));
+    QDir().mkpath(QStringLiteral(KSIEVEUI_BINARY_DATA_DIR));
     QString script = readSieveFile(originalFile);
     // First parsing
     bool result = false;

src/ksieveui/autocreatescripts/sieveconditions/widgets/selectsizewidget.cpp

@@ -14,8 +14,8 @@ using namespace KSieveUi;
 
 SelectSizeWidget::SelectSizeWidget(QWidget *parent)
     : QWidget(parent)
-    , mSpinBoxSize(new QSpinBox(this))
     , mSelectSizeType(new SelectSizeTypeComboBox(this))
+    , mSpinBoxSize(new QSpinBox(this))
 {
     auto hbox = new QHBoxLayout(this);
     hbox->setContentsMargins({});

src/ksieveui/debug/sievedebugdialog.cpp

@@ -111,7 +111,7 @@ void SieveDebugDialog::slotDiagNextAccount()
         connect(mShutDownJob, &QTimer::timeout, this, &SieveDebugDialog::slotShutDownJob);
     }
     mShutDownJob->start(30 * 1000); // 30 seconds
-    const QString ident = mResourceIdentifier.first();
+    const QString ident = mResourceIdentifier.constFirst();
 
     mEdit->editor()->appendPlainText(i18n("Collecting data for account '%1'...\n", ident));
     mEdit->editor()->appendPlainText(i18n("------------------------------------------------------------\n"));

src/ksieveui/vacation/legacy/vacationutils.cpp

@@ -105,8 +105,8 @@ QString Legacy::VacationUtils::composeScript(const QString &messageText,
                                              const AddrSpecList &addrSpecs,
                                              bool sendForSpam,
                                              const QString &domain,
-                                             const QDate &startDate,
-                                             const QDate &endDate)
+                                             QDate startDate,
+                                             QDate endDate)
 {
     QString addressesArgument;
     QStringList aliases;

src/ksieveui/vacation/legacy/vacationutils.h

@@ -43,8 +43,8 @@ QString KSIEVEUI_DEPRECATED composeScript(const QString &messageText,
                                           const KMime::Types::AddrSpecList &aliases,
                                           bool sendForSpam,
                                           const QString &excludeDomain,
-                                          const QDate &startDate,
-                                          const QDate &endDate);
+                                          QDate startDate,
+                                          QDate endDate);
 
 /*
 

src/ksieveui/vacation/vacationcheckjob.h

@@ -33,12 +33,12 @@ public:
     Q_REQUIRED_RESULT QString serverName() const;
 
 Q_SIGNALS:
-    void vacationScriptActive(VacationCheckJob *job, const QString &sscriptName, bool active);
+    void vacationScriptActive(KSieveUi::VacationCheckJob *job, const QString &sscriptName, bool active);
     void error(const QString &errorStr);
 
 private Q_SLOTS:
     void slotGetResult(KManageSieve::SieveJob *job, bool success, const QString &script, bool active);
-    void slotGotActiveScripts(ParseUserScriptJob *job);
+    void slotGotActiveScripts(KSieveUi::ParseUserScriptJob *job);
     void slotGotList(KManageSieve::SieveJob *job, bool success, const QStringList &availableScripts, const QString &activeScript);
     void emitError(const QString &errorMessage);
     void searchVacationScript();

src/ksieveui/widgets/managesievewidget.h

@@ -49,8 +49,8 @@ public:
 
 Q_SIGNALS:
     void updateButtons(QTreeWidgetItem *item);
-    void newScript(const ScriptInfo &info);
-    void editScript(const ScriptInfo &info);
+    void newScript(const KSieveUi::ManageSieveWidget::ScriptInfo &info);
+    void editScript(const KSieveUi::ManageSieveWidget::ScriptInfo &info);
     void scriptDeleted(const QUrl &u);
     void serverSieveFound(bool imapFound);
     void scriptRenamed(const QUrl &oldUrl, const QUrl &newUrl);
@@ -67,7 +67,7 @@ private Q_SLOTS:
     void slotDoubleClicked(QTreeWidgetItem *item);
     void slotSystemNetworkOnlineStateChanged(bool state);
     void slotCheckNetworkStatus();
-    void setActiveScripts(ParseUserScriptJob *job);
+    void setActiveScripts(KSieveUi::ParseUserScriptJob *job);
 
     void slotCancelFetch();
     void slotRenameResult(KManageSieve::SieveJob *job, bool success);