1. 04 Jun, 2020 1 commit
  2. 24 Mar, 2020 1 commit
  3. 01 Jan, 2020 1 commit
  4. 27 Dec, 2018 1 commit
  5. 23 Jul, 2018 1 commit
  6. 20 Jul, 2018 1 commit
  7. 03 Jul, 2018 1 commit
  8. 27 Jun, 2018 1 commit
  9. 01 Jan, 2018 1 commit
  10. 06 Oct, 2017 1 commit
  11. 22 Apr, 2017 1 commit
  12. 25 Mar, 2017 1 commit
  13. 14 Feb, 2017 1 commit
  14. 02 Jan, 2017 1 commit
  15. 01 Jan, 2017 1 commit
  16. 18 Jul, 2016 1 commit
    • David Faure's avatar
      KSieve: redesign to fix error handling. · 109c43fe
      David Faure authored
      * Fix parsing of "NO {123}" (followed by error lines). The thread separation
      broke Volker's "feedback" hack^H^H^H^Hdesign, because the state is wrong at the
      time the reparsing happens. This syntax is now handled during response parsing
      rather than being fed back to the thread.
      
      * Fix double messagebox on error, because on destruction the job would call
      killJob which would emit the error again. To fix this I followed more closely
      the KJob API (even though SieveJob isn't a KJob), using the (currently unused)
      KillVerbosity argument.
      
      * Fix some error messages being stored in Session and never shown, now those
      are given to the current job. This also goes closer to KJob: errorString()
      in the job rather than an errorMessage signal.
      
      * Finally, remove messageboxes shown by the job itself (and setInteractive(false)
      to disable that), let the caller show a messagebox on error if it wants to
      (again, more like KJob). This fixes ugly reentrancy problems while the msgbox
      is up from within the job code, and allows to customize the error messages better.
      
      Differential Revision: https://phabricator.kde.org/D2189
      109c43fe
  17. 02 Jan, 2016 1 commit
  18. 09 Dec, 2015 2 commits