Commit 9554c26b authored by Laurent Montel's avatar Laurent Montel 😁

Modernize code

parent 1662475b
Pipeline #33667 failed with stage
in 124 minutes and 21 seconds
...@@ -182,8 +182,8 @@ Q_SIGNALS: ...@@ -182,8 +182,8 @@ Q_SIGNALS:
void filterActionModified(); void filterActionModified();
private: private:
QString mName; const QString mName;
QString mLabel; const QString mLabel;
}; };
} }
......
...@@ -20,7 +20,7 @@ public: ...@@ -20,7 +20,7 @@ public:
void convert(); void convert();
private: private:
QVector<MailFilter *> mListFilters; const QVector<MailFilter *> mListFilters;
}; };
} }
#endif // FILTERCONVERTTOSIEVE_H #endif // FILTERCONVERTTOSIEVE_H
...@@ -85,7 +85,6 @@ static const int numMdnMessageBoxes ...@@ -85,7 +85,6 @@ static const int numMdnMessageBoxes
MDNAdviceDialog::MDNAdviceDialog(const QString &text, bool canDeny, QWidget *parent) MDNAdviceDialog::MDNAdviceDialog(const QString &text, bool canDeny, QWidget *parent)
: QDialog(parent) : QDialog(parent)
, m_result(MessageComposer::MDNIgnore)
{ {
setWindowTitle(i18nc("@title:window", "Message Disposition Notification Request")); setWindowTitle(i18nc("@title:window", "Message Disposition Notification Request"));
QPushButton *user1Button = nullptr; QPushButton *user1Button = nullptr;
......
...@@ -76,7 +76,7 @@ private: ...@@ -76,7 +76,7 @@ private:
void slotUser1Clicked(); void slotUser1Clicked();
void slotUser2Clicked(); void slotUser2Clicked();
void slotYesClicked(); void slotYesClicked();
MessageComposer::MDNAdvice m_result; MessageComposer::MDNAdvice m_result = MessageComposer::MDNIgnore;
protected: protected:
......
...@@ -39,7 +39,7 @@ public: ...@@ -39,7 +39,7 @@ public:
delete kernel; delete kernel;
} }
Kernel *kernel; Kernel *const kernel;
}; };
Q_GLOBAL_STATIC(KernelPrivate, sInstance) Q_GLOBAL_STATIC(KernelPrivate, sInstance)
......
...@@ -33,7 +33,6 @@ using namespace MailCommon; ...@@ -33,7 +33,6 @@ using namespace MailCommon;
MailCommon::RuleWidgetHandlerManager *MailCommon::RuleWidgetHandlerManager::self = nullptr; MailCommon::RuleWidgetHandlerManager *MailCommon::RuleWidgetHandlerManager::self = nullptr;
MailCommon::RuleWidgetHandlerManager::RuleWidgetHandlerManager() MailCommon::RuleWidgetHandlerManager::RuleWidgetHandlerManager()
: mIsBalooSearch(false)
{ {
registerHandler(new MailCommon::TagRuleWidgetHandler()); registerHandler(new MailCommon::TagRuleWidgetHandler());
registerHandler(new MailCommon::DateRuleWidgetHandler()); registerHandler(new MailCommon::DateRuleWidgetHandler());
......
...@@ -66,7 +66,7 @@ private: ...@@ -66,7 +66,7 @@ private:
typedef QVector<const RuleWidgetHandler *>::iterator iterator; typedef QVector<const RuleWidgetHandler *>::iterator iterator;
QVector<const RuleWidgetHandler *> mHandlers; QVector<const RuleWidgetHandler *> mHandlers;
bool mIsBalooSearch; bool mIsBalooSearch = false;
}; };
} // namespace MailCommon } // namespace MailCommon
......
...@@ -35,7 +35,7 @@ private Q_SLOTS: ...@@ -35,7 +35,7 @@ private Q_SLOTS:
void onTagsFetched(KJob *); void onTagsFetched(KJob *);
private: private:
QComboBox * mComboBox = nullptr; QComboBox *mComboBox = nullptr;
}; };
FillTagComboJob::FillTagComboJob(QComboBox *combo, QObject *parent) FillTagComboJob::FillTagComboJob(QComboBox *combo, QObject *parent)
......
...@@ -32,7 +32,7 @@ private: ...@@ -32,7 +32,7 @@ private:
void writeConfig(); void writeConfig();
void readConfig(); void readConfig();
void slotAccepted(); void slotAccepted();
QString mVariableName; const QString mVariableName;
QMap<QString, QString> *mVariables = nullptr; QMap<QString, QString> *mVariables = nullptr;
KPIMTextEdit::PlainTextEditorWidget *mVariableValueText = nullptr; KPIMTextEdit::PlainTextEditorWidget *mVariableValueText = nullptr;
QCheckBox *mSaveVariable = nullptr; QCheckBox *mSaveVariable = nullptr;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment