Commit 38a32283 authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Const'ify pointer + add missing override

parent cfb7ca18
Pipeline #54632 skipped
......@@ -15,7 +15,7 @@ class ConversationViewWidget : public QWidget
Q_OBJECT
public:
explicit ConversationViewWidget(QWidget *parent = nullptr);
~ConversationViewWidget();
~ConversationViewWidget() override;
};
}
......
......@@ -22,6 +22,7 @@ public:
private:
explicit FindBarSourceView(QWidget *parent)
: mView(nullptr)
{
Q_UNUSED(parent)
}
......@@ -32,7 +33,7 @@ private:
void updateSensitivity(bool) override;
private:
QPlainTextEdit *mView = nullptr;
QPlainTextEdit *const mView;
};
}
......
......@@ -99,7 +99,6 @@ using namespace MessageViewer;
MessagePartRendererManager::MessagePartRendererManager(QObject *parent)
: QObject(parent)
, m_engine(nullptr)
, m_globalContext(new GlobalContext(this))
{
initializeRenderer();
......
......@@ -34,7 +34,7 @@ class MESSAGEVIEWER_EXPORT MessagePartRendererManager : public QObject
Q_OBJECT
public:
explicit MessagePartRendererManager(QObject *parent = nullptr);
~MessagePartRendererManager();
~MessagePartRendererManager() override;
static MessagePartRendererManager *self();
Q_REQUIRED_RESULT Grantlee::Template loadByName(const QString &name);
......
......@@ -28,8 +28,8 @@ public:
private:
void initializePlugin();
GrantleeHeaderStyle *mHeaderStyle = nullptr;
HeaderStrategy *mHeaderStrategy = nullptr;
GrantleeHeaderStyle *const mHeaderStyle;
HeaderStrategy *const mHeaderStrategy;
};
}
#endif // DEFAULTGRANTLEEHEADERSTYLEPLUGIN_H
......@@ -16,21 +16,16 @@
using namespace MessageViewer;
RemoteContentMenu::RemoteContentMenu(QWidget *parent)
: QMenu(parent)
, mConfigureRemoteContentAction(new QAction(i18n("Configure"), this))
{
setTitle(i18n("Remote Content"));
connect(this, &QMenu::aboutToShow, this, &RemoteContentMenu::updateMenu);
initialize();
}
RemoteContentMenu::~RemoteContentMenu()
{
}
void RemoteContentMenu::initialize()
{
mConfigureRemoteContentAction = new QAction(i18n("Configure"), this);
}
void RemoteContentMenu::slotConfigure()
{
QPointer<MessageViewer::RemoteContentConfigureDialog> remoteContentDialog = new MessageViewer::RemoteContentConfigureDialog(this);
......
......@@ -27,11 +27,10 @@ public:
void appendUrl(const QString &url);
private:
void initialize();
void authorize(const QString &url);
void slotConfigure();
QStringList mUrls;
QAction *mConfigureRemoteContentAction = nullptr;
QAction *const mConfigureRemoteContentAction;
QList<QAction *> mListAction;
};
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment