Fix api

CMakeLists.txt

@@ -18,7 +18,7 @@ include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
 include(ECMQtDeclareLoggingCategory)
 include(ECMAddTests)
 
-set(MESSAGELIB_LIB_VERSION "5.2.41")
+set(MESSAGELIB_LIB_VERSION "5.2.42")
 
 set(KF5_VERSION "5.19.0")
 set(KDEPIMLIBS_LIB_VERSION "5.2.40")

messageviewer/src/webengine/urlinterceptor/networkpluginurlinterceptor.cpp

@@ -30,11 +30,6 @@ NetworkPluginUrlInterceptor::~NetworkPluginUrlInterceptor()
 
 }
 
-void NetworkPluginUrlInterceptor::createActions(KActionCollection *ac)
-{
-    Q_UNUSED(ac);
-}
-
 bool NetworkPluginUrlInterceptor::hasConfigureSupport() const
 {
     return false;
@@ -45,8 +40,3 @@ MessageViewer::NetworkPluginUrlInterceptorConfigureWidget *NetworkPluginUrlInter
     Q_UNUSED(parent);
     return Q_NULLPTR;
 }
-
-QList<QAction *> MessageViewer::NetworkPluginUrlInterceptor::actions() const
-{
-    return {};
-}

messageviewer/src/webengine/urlinterceptor/networkpluginurlinterceptor.h

@@ -34,8 +34,6 @@ public:
     ~NetworkPluginUrlInterceptor();
     virtual NetworkPluginUrlInterceptorInterface *createInterface(QObject *parent = Q_NULLPTR) = 0;
 
-    virtual void createActions(KActionCollection *ac);
-    virtual QList<QAction *> actions() const;
     virtual bool hasConfigureSupport() const;
     virtual MessageViewer::NetworkPluginUrlInterceptorConfigureWidget *createConfigureWidget(QWidget *parent = Q_NULLPTR);
 };

messageviewer/src/webengine/urlinterceptor/networkpluginurlinterceptorinterface.cpp

@@ -29,3 +29,13 @@ NetworkPluginUrlInterceptorInterface::~NetworkPluginUrlInterceptorInterface()
 {
 
 }
+
+void NetworkPluginUrlInterceptorInterface::createActions(KActionCollection *ac)
+{
+    Q_UNUSED(ac);
+}
+
+QList<QAction *> NetworkPluginUrlInterceptorInterface::actions() const
+{
+    return {};
+}

messageviewer/src/webengine/urlinterceptor/networkpluginurlinterceptorinterface.h

@@ -21,6 +21,8 @@
 #include <QObject>
 #include "messageviewer_export.h"
 class QWebEngineUrlRequestInfo;
+class KActionCollection;
+class QAction;
 namespace MessageViewer
 {
 class MESSAGEVIEWER_EXPORT NetworkPluginUrlInterceptorInterface : public QObject
@@ -30,6 +32,9 @@ public:
     explicit NetworkPluginUrlInterceptorInterface(QObject *parent = Q_NULLPTR);
     ~NetworkPluginUrlInterceptorInterface();
 
+    virtual void createActions(KActionCollection *ac);
+    virtual QList<QAction *> actions() const;
+
     virtual void interceptRequest(QWebEngineUrlRequestInfo &info) = 0;
 };
 }

messageviewer/src/webengine/urlinterceptor/networkurlinterceptormanager.cpp

@@ -15,6 +15,7 @@
   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 */
 
+#include "networkpluginurlinterceptorinterface.h"
 #include "networkurlinterceptormanager.h"
 #include "networkurlinterceptorpluginmanager.h"
 
@@ -37,7 +38,7 @@ void NetworkUrlInterceptorManagerPrivate::createInterfaces(KActionCollection *ac
 {
     Q_FOREACH (NetworkPluginUrlInterceptor *plugin, NetworkUrlInterceptorPluginManager::self()->pluginsList()) {
         MessageViewer::NetworkPluginUrlInterceptorInterface *interface = plugin->createInterface(q);
-        plugin->createActions(ac);
+        interface->createActions(ac);
         mListInterface.append(interface);
     }
 }