From 4b2bb9bfc0d083e0078b98a76a37791afbd3ca03 Mon Sep 17 00:00:00 2001
From: Montel Laurent <montel@kde.org>
Date: Mon, 23 May 2016 07:08:30 +0200
Subject: [PATCH] Improve autotests. Add more signals

---
 .../src/autotests/webengineexporthtmlpagejobtest.cpp        | 6 ++++++
 webengineviewer/src/webengineexporthtmlpagejob.cpp          | 1 +
 webengineviewer/src/webengineexporthtmlpagejob.h            | 1 +
 3 files changed, 8 insertions(+)

diff --git a/webengineviewer/src/autotests/webengineexporthtmlpagejobtest.cpp b/webengineviewer/src/autotests/webengineexporthtmlpagejobtest.cpp
index 6b4decbe..aec6d657 100644
--- a/webengineviewer/src/autotests/webengineexporthtmlpagejobtest.cpp
+++ b/webengineviewer/src/autotests/webengineexporthtmlpagejobtest.cpp
@@ -17,6 +17,7 @@
 
 #include "webengineexporthtmlpagejobtest.h"
 #include "../webengineexporthtmlpagejob.h"
+#include <QSignalSpy>
 #include <QTest>
 
 WebEngineExportHtmlPageJobTest::WebEngineExportHtmlPageJobTest(QObject *parent)
@@ -33,7 +34,12 @@ WebEngineExportHtmlPageJobTest::~WebEngineExportHtmlPageJobTest()
 void WebEngineExportHtmlPageJobTest::shouldHaveDefaultValue()
 {
     WebEngineViewer::WebEngineExportHtmlPageJob job;
+    QSignalSpy spyFailed(&job, SIGNAL(failed()));
+    QSignalSpy spySuccess(&job, SIGNAL(success(QString)));
     QVERIFY(!job.engineView());
+    job.start();
+    QCOMPARE(spyFailed.count(), 1);
+    QCOMPARE(spySuccess.count(), 0);
 }
 
 QTEST_MAIN(WebEngineExportHtmlPageJobTest)
diff --git a/webengineviewer/src/webengineexporthtmlpagejob.cpp b/webengineviewer/src/webengineexporthtmlpagejob.cpp
index b7199c85..90876bbf 100644
--- a/webengineviewer/src/webengineexporthtmlpagejob.cpp
+++ b/webengineviewer/src/webengineexporthtmlpagejob.cpp
@@ -16,6 +16,7 @@
 */
 
 #include "webengineexporthtmlpagejob.h"
+#include "config-webengineviewer.h"
 
 using namespace WebEngineViewer;
 
diff --git a/webengineviewer/src/webengineexporthtmlpagejob.h b/webengineviewer/src/webengineexporthtmlpagejob.h
index 35df796c..9d0cc49b 100644
--- a/webengineviewer/src/webengineexporthtmlpagejob.h
+++ b/webengineviewer/src/webengineexporthtmlpagejob.h
@@ -36,6 +36,7 @@ public:
 
 Q_SIGNALS:
     void failed();
+    void success(const QString &filename);
 
 private:
     QWebEngineView *mEngineView;
-- 
GitLab