Commit 4b469f16 authored by David Faure's avatar David Faure

Remove moveCompletionPopup() hack.

Summary:
1) commit b78a77e95659 in kdelibs 4.9.2 (see bug 270473) takes
care of making KCompletionBox move/resize when the parent widget has moved/resized.

2) this hack made the completion popup not appear for me, the very first time.
After hide()+show(), isVisible() was true, but the popup wasn't actually visible
(geometry was correct though). Possibly a Qt issue, but that's what we get when
doing hacks.
Worse, this broke the Tab key to focus the next field, since the code thought
it was about tabbing through the presumed-to-be-visible completion box.
parent 41302b1b
......@@ -237,17 +237,6 @@ void RecipientLineNG::clear()
mEdit->clear();
}
void RecipientLineNG::moveCompletionPopup()
{
if (mEdit->completionBox(false)) {
if (mEdit->completionBox()->isVisible()) {
// ### trigger moving, is there a nicer way to do that?
mEdit->completionBox()->hide();
mEdit->completionBox()->show();
}
}
}
void RecipientLineNG::setCompletionMode(KCompletion::CompletionMode mode)
{
mEdit->setCompletionMode(mode);
......
......@@ -83,7 +83,6 @@ public:
void fixTabOrder(QWidget *previous) Q_DECL_OVERRIDE;
QWidget *tabOut() const Q_DECL_OVERRIDE;
void moveCompletionPopup() Q_DECL_OVERRIDE;
void setCompletionMode(KCompletion::CompletionMode mode) Q_DECL_OVERRIDE;
int setColumnWidth(int w) Q_DECL_OVERRIDE;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment