Commit 4e32803d authored by David Faure's avatar David Faure

Make message switching in kmail much faster (also fixes a focus issue)

This call to load() triggers a lot of internal stuff in WebEngine,
including NavigateToEntry, creation (and soon afterwards, deletion) of
QtWebEngineCore::RenderWidgetHostViewQtDelegateWidget, etc.

I can't see any regression when removing this call.

On the contrary, this fixes a focus issue: when clicking on an
external link in an email and coming back to kmail, arrow up/down
didn't work anymore, because the last widget installed as focusproxy
for the webview (the DelegateWidget above) had been deleted meanwhile.

Differential Revision: https://phabricator.kde.org/D2637
parent a5e0e621
...@@ -48,11 +48,6 @@ void WebEnginePartHtmlWriter::begin(const QString &css) ...@@ -48,11 +48,6 @@ void WebEnginePartHtmlWriter::begin(const QString &css)
} }
MessageViewer::WebEngineEmbedPart::self()->clear(); MessageViewer::WebEngineEmbedPart::self()->clear();
// clear the widget:
mHtmlView->setUpdatesEnabled(false);
mHtmlView->scrollUp(10);
// PENDING(marc) push into MailWebView
mHtmlView->load(QUrl());
mState = Begun; mState = Begun;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment