Start to fix print to pdf

CCBUG: 422095

messageviewer/src/viewer/viewer_p.cpp

@@ -2372,8 +2372,24 @@ void ViewerPrivate::slotPrintMessage()
         delete dialog;
         return;
     }
+    if (dialog->printer()->outputFormat() == QPrinter::PdfFormat) {
+        mViewer->page()->printToPdf(dialog->printer()->outputFileName(), dialog->printer()->pageLayout());
+        connect(mViewer->page(), &QWebEnginePage::pdfPrintingFinished, this, &ViewerPrivate::slotPdfPrintingFinished);
+    } else {
+        mViewer->page()->print(mCurrentPrinter, invoke(this, &ViewerPrivate::slotHandlePagePrinted));
+    }
     delete dialog;
-    mViewer->page()->print(mCurrentPrinter, invoke(this, &ViewerPrivate::slotHandlePagePrinted));
+}
+
+void ViewerPrivate::slotPdfPrintingFinished(const QString &filePath, bool success)
+{
+    Q_UNUSED(filePath)
+    if (!success) {
+        qCWarning(MESSAGEVIEWER_LOG) << "Print to pdf failed";
+    }
+    delete mCurrentPrinter;
+    mCurrentPrinter = nullptr;
+    Q_EMIT printingFinished();
 }
 
 void ViewerPrivate::slotHandlePagePrinted(bool result)

messageviewer/src/viewer/viewer_p.h

@@ -588,11 +588,12 @@ private:
     void slotDelayPrintPreview();
     void applyZoomValue(qreal factor, bool saveConfig = true);
     void slotZoomChanged(qreal zoom);
+    void assignMessageItem(const Akonadi::Item &item);
+    void slotPdfPrintingFinished(const QString &filePath, bool success);
     MimeTreeParser::NodeHelper *mNodeHelper = nullptr;
     bool mHtmlMailGlobalSetting = false;
     bool mHtmlLoadExternalDefaultSetting = false;
     bool mHtmlLoadExtOverride = false;
-    void assignMessageItem(const Akonadi::Item &item);
 public:
     KMime::Message::Ptr mMessage; //the current message, if it was set manually
     Akonadi::Item mMessageItem; //the message item from Akonadi

[Kevin Kofler]

Uhm, shouldn't we connect to the signal before invoking the method that may trigger it?