Add const'ref

messagecomposer/src/composer/composerviewbase.cpp

@@ -648,7 +648,7 @@ QList< MessageComposer::Composer * > ComposerViewBase::generateCryptoMessages(bo
     }
 
     if (m_attachmentModel) {
-        foreach (MessageCore::AttachmentPart::Ptr attachment, m_attachmentModel->attachments()) {
+        foreach (const MessageCore::AttachmentPart::Ptr &attachment, m_attachmentModel->attachments()) {
             if (attachment->isSigned()) {
                 signSomething = true;
             } else {

messagecomposer/src/job/generatecryptomessagesjob.cpp

@@ -20,6 +20,7 @@
 #include "messagecomposer_debug.h"
 #include "settings/messagecomposersettings.h"
 #include "composer/keyresolver.h"
+#include <KLocalizedString>
 
 using namespace MessageComposer;
 
@@ -163,7 +164,7 @@ QList< MessageComposer::Composer * > ComposerViewBase::generateCryptoMessages(bo
     }
 
     if (m_attachmentModel) {
-        foreach (MessageCore::AttachmentPart::Ptr attachment, m_attachmentModel->attachments()) {
+        foreach (const MessageCore::AttachmentPart::Ptr &attachment, m_attachmentModel->attachments()) {
             if (attachment->isSigned()) {
                 signSomething = true;
             } else {

messagecomposer/src/job/generatecryptomessagesjob.h

@@ -29,8 +29,9 @@ class GenerateCryptoMessagesJob : public QObject
 public:
     explicit GenerateCryptoMessagesJob(QObject *parent = nullptr);
     ~GenerateCryptoMessagesJob();
-private:
 
+Q_SIGNALS:
+    void failed(const QString &msg);
 };
 }