GitLab

FIXED-IN: 5.6.0
BUG: 383008

FIXED-IN: 5.6.0
BUG: 381424

Convert it to QLineEdit as it's a bug in klineedit + new qt
I don't know where is the bug and I don't have time to investigate it.
And this lineedit doesn't need to have klineedit feature

Setting to the last item would miss checking the last item itself,
so the method would return -1 by mistake if the last item was the one we
were looking for.

Arguably it would be faster to do a reverse search in that case though.

Note that removing the -1 in qMin wouldn't work either, bwdIt==end skips
all backward search.

CCMAIL: dvratil@kde.org

Reviewed by Dan Vratil

Reviewed by Dan Vratil.

If mThisItemIndexGuess is out of date then we will search for the item
in both directions from the old guess. Since in most cases the item has
only moved a few rows up or down, searching from the old guess means we
find the item faster than if we would just search from the beginning of
the container.

Use range-based for loops and "auto" where it makes sense.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Test Plan:
Starting and quitting kmail multiple times used to make the first column grow
every time.

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: #kde_pim

Differential Revision: https://phabricator.kde.org/D5763

Summary:
On startup the column sizes were calculated for a viewport without
vertical scrollbar, and then not adjusted when the vertical scrollbar
later appears. My fix is to simply always recalculate column sizes
when the viewport is resized at any point. If I resize the mainwindow
I still don't want a horizontal scrollbar under the messagelist.

This removes the need for showEvent since any change of size triggers
resizeEvent anyway. I also can't see any use for recalculating the
sizes on model reset (e.g. switching folders), QHeaderView appears to
just keep the column sizes when doing that (might be my own QHeaderView
fix, actually).

Test Plan: starting kmail, switching folders, resizing columns...

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: dvratil, mkoller, #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D5724

Reviewed-by: Laurent