GitLab

Deleting the first attachment triggers an update of the message. In case
of IMAP this is done by adding a new message and deleting the old one.
This changes the remote id of the message. The problem was that after
deleting the second attachment the update of the message tried to set
the old remote id. This fails because only the server can set a remote id.
This problem is fixed by clearing the remote id before starting an
ItemModifyJob.

Funded by: Intevation GmbH

BUG: 282792
FIXED-IN: 5.18.0

It broke the build due to use of APIs that are deprecated in the new
KF_DISABLE_DEPRECATED_BEFORE_AND_AT setting.

This reverts commit ae99479f.

Ingo Klöcker authored Apr 29, 2021 and Albert Astals Cid committed Apr 29, 2021

Deleting an attachment of a decrypted encrypted message stored on a remote server
(e.g. an IMAP server) causes KMail to upload the decrypted content of the message
to the remote server. This is not easily noticeable by the user because KMail does
not display the decrypted content.

Q_UNUSED_RESULT on void return type doesn't make sense

Doesn't make sense to allow it using the right mouse button

showContextMenu() is only called for content nodes from the mime part
tree, but the mime part tree has a separate copy of the node tree.
Therefore, isRoot was always false. Check content->isTopLevel() instead
of comparing pointers.

Deletion of attachments (and other message parts) is only allowed
one at a time. Message parts inside encrypted message parts cannot
be deleted.

This (re-)adds the "Delete Attachment" action to the context menu
of the message structure view. It was removed 3 years ago because
it always crashed (because it tried to work with a copy of the node
tree of the original message).

Sponsored by: Intevation GmbH

CCBUG: 287177
BUG: 436089
FIXED-IN: 5.18.0