1. 04 Dec, 2019 2 commits
  2. 01 Oct, 2019 1 commit
  3. 21 Sep, 2019 1 commit
  4. 25 Aug, 2019 1 commit
  5. 21 Jul, 2019 1 commit
    • Krzysztof Nowicki's avatar
      Use system codepage when reading from piped command · adede5ee
      Krzysztof Nowicki authored
      Summary:
      When using a piped command to preprocess the message the response may contain locale-specific characters. When converting using Latin1 those characters are mangled.
      
      This fixes preprocessing messages which contain Unicode characters.
      
      Test Plan: Use a piped command that generates non-ASCII characters in the response. Make sure that these characters appear properly in the editor window.
      
      Reviewers: dvratil, mlaurent, #kde_pim
      
      Reviewed By: dvratil, #kde_pim
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D19333
      adede5ee
  6. 12 May, 2019 1 commit
    • Sandro Knauß's avatar
      Make unexpected data leak harder via reply. · 8f9b85b6
      Sandro Knauß authored
      ObjectTreeParser.htmlContent/plainTextContent may concats different encrypted parts
      without the user noticing it. That would lead to a Decryption oracle. We have already
      a logic to find the topleveltextNode in MimeTreeParser, this does not take HTML nodes
      into account nor that TEXT nodes may have several PGP Inline blocks.
      
      That plaintextContent for HtmlMessagePart is not return QString(), that bubbled up by
      testing the stuff.
      
      BUG: 404698
      8f9b85b6
  7. 21 Mar, 2019 2 commits
  8. 27 Dec, 2018 1 commit
  9. 03 Dec, 2018 2 commits
    • Laurent Montel's avatar
      Revert "Fix leak in templateparserjob" · eedac2ff
      Laurent Montel authored
      This reverts commit 0161e0bb.
      
      It crashs when we forward as inline
      eedac2ff
    • Kevin Funk's avatar
      Fix leak in templateparserjob · 0161e0bb
      Kevin Funk authored
      ASAN trace
      Indirect leak of 176 byte(s) in 2 object(s) allocated from:
          #0 0x52a000 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/kmail+0x52a000)
          #1 0x7fc933d0d3ef in KMime::Content::Content(KMime::Content*) /home/kfunk/devel/src/kf5/kmime/src/kmime_content.cpp:60:13
          #2 0x7fc9386f630e in TemplateParser::TemplateParserJob::createPlainPartContent(QString const&) const /home/kfunk/devel/src/kf5/messagelib/templateparser/src/templateparserjob.cpp:1276:36
          #3 0x7fc9386f5f8d in TemplateParser::TemplateParserJob::addProcessedBodyToMessage(QString const&, QString const&) const /home/kfunk/devel/src/kf5/messagelib/templateparser/src/templateparserjob.cpp:1204:13
          #4 0x7fc9386f43d8 in TemplateParser::TemplateParserJob::slotExtractInfoDone(TemplateParserExtractHtmlInfoResult const&) /home/kfunk/devel/src/kf5/messagelib/templateparser/src/templateparserjob.cpp:1132:5
          ...
      0161e0bb
  10. 22 Nov, 2018 2 commits
  11. 01 Oct, 2018 1 commit
  12. 07 Sep, 2018 1 commit
  13. 03 Feb, 2018 1 commit
  14. 01 Jan, 2018 1 commit
  15. 27 Dec, 2017 1 commit
  16. 01 Dec, 2017 1 commit
  17. 09 Nov, 2017 1 commit
  18. 31 Oct, 2017 1 commit
  19. 14 Sep, 2017 1 commit
  20. 10 Sep, 2017 1 commit
  21. 03 Sep, 2017 1 commit
  22. 12 Jun, 2017 2 commits
  23. 08 Jun, 2017 2 commits
  24. 24 Apr, 2017 1 commit
  25. 09 Apr, 2017 2 commits
  26. 23 Feb, 2017 1 commit
  27. 12 Feb, 2017 1 commit
  28. 11 Feb, 2017 1 commit
  29. 10 Feb, 2017 1 commit
  30. 08 Feb, 2017 4 commits