GitLab

Christophe Giboudeaux authored Jul 02, 2020 and Laurent Montel committed Jul 02, 2020

GIT_SILENT

Summary:
The pasring part is done with this patch, but for the user it is not
visible as we need to make sure, that we first create the MimeTree and
afterwards render the header and than the body.

Subscribers: kde-pim

Tags: #kde_pim

Maniphest Tasks: T742

Differential Revision: https://phabricator.kde.org/D23649

This reverts commit b203c17e.

It's already delete in destructor see line 80, we clean temporary file +
delete this pointer.

ASAN trace:
Indirect leak of 48 byte(s) in 2 object(s) allocated from:
    #0 0x52a000 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/kmail+0x52a000)
    #1 0x7fbadd2548fb in MimeTreeParser::NodeHelper::removeTempFiles() /home/kfunk/devel/src/kf5/messagelib/mimetreeparser/src/nodehelper.cpp:340:27
    #2 0x7fbaddf8b7ac in MessageViewer::ViewerPrivate::parseContent(KMime::Content*) /home/kfunk/devel/src/kf5/messagelib/messageviewer/src/viewer/viewer_p.cpp:904:18
    #3 0x7fbaddf8b1c6 in MessageViewer::ViewerPrivate::displayMessage() /home/kfunk/devel/src/kf5/messagelib/messageviewer/src/viewer/viewer_p.cpp:885:5
    ...

Summary:
To make it possible to display memoryhole correcly to the user,
MimeTreeParser needs to have the ability to update/change headers.
For this we need an interface to change the headers.

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D15760

Maniphest Tasks: T8568