Tests: avoid building CPP files that are exported from a linked SO as well

MSVC doesn't like when the same symbol appears in the executable as well
as in the linked library. Since the symbol is experted, there's no need
to explicitly build the CPP file as part of the test.

messagecomposer/autotests/CMakeLists.txt

@@ -94,7 +94,7 @@ if (KDEPIM_RUN_AKONADI_TEST)
 	set(KDEPIMLIBS_RUN_ISOLATED_TESTS TRUE)
 	set(KDEPIMLIBS_RUN_SQLITE_ISOLATED_TESTS TRUE)
 
-	add_akonadi_isolated_test_advanced( followupreminderselectdatedialogtest.cpp  "../src/followupreminder/followupreminderselectdatedialog.cpp" "KF5::CalendarCore;KF5::AkonadiCore;KF5::AkonadiWidgets;KF5::MessageComposer;KF5::I18n")
+	add_akonadi_isolated_test_advanced(followupreminderselectdatedialogtest.cpp "" "KF5::CalendarCore;KF5::AkonadiCore;KF5::AkonadiWidgets;KF5::MessageComposer;KF5::I18n")
 
-	add_akonadi_isolated_test_advanced( attachmentvcardfromaddressbookjobtest.cpp "../src/job/attachmentvcardfromaddressbookjob.cpp" "KF5::CalendarCore;KF5::AkonadiCore;KF5::AkonadiWidgets;KF5::MessageComposer;KF5::Contacts;KF5::AkonadiContact;KF5::I18n")
+	add_akonadi_isolated_test_advanced(attachmentvcardfromaddressbookjobtest.cpp "" "KF5::CalendarCore;KF5::AkonadiCore;KF5::AkonadiWidgets;KF5::MessageComposer;KF5::Contacts;KF5::AkonadiContact;KF5::I18n")
 endif()

webengineviewer/src/checkphishingurl/autotests/CMakeLists.txt

@@ -2,27 +2,25 @@ set(testwebengineviewer_webengine_common_SRCS)
 ecm_qt_declare_logging_category(testwebengineviewer_webengine_common_SRCS HEADER webengineviewer_debug.h IDENTIFIER WEBENGINEVIEWER_LOG CATEGORY_NAME org.kde.pim.webengineviewer)
 add_definitions( -DCHECKPHISHINGURL_DATA_DIR="${CMAKE_CURRENT_SOURCE_DIR}/data" )
 
-ecm_add_test(checkphishingurljobtest.cpp  ../checkphishingurljob.cpp ../updatedatabaseinfo.cpp ../checkphishingurlutil.cpp ${testwebengineviewer_webengine_common_SRCS}
+ecm_add_test(checkphishingurljobtest.cpp ${testwebengineviewer_webengine_common_SRCS}
     TEST_NAME checkphishingurljobtest
     NAME_PREFIX "webengineview-"
     LINK_LIBRARIES Qt5::Test KF5::WebEngineViewer
     )
 
-ecm_add_test(createphishingurldatabasejobtest.cpp ../checkphishingurlutil.cpp ../updatedatabaseinfo.cpp ../createphishingurldatabasejob.cpp ${testwebengineviewer_webengine_common_SRCS}
+ecm_add_test(createphishingurldatabasejobtest.cpp ${testwebengineviewer_webengine_common_SRCS}
     TEST_NAME createphishingurldatabasejobtest
     NAME_PREFIX "webengineview-"
     LINK_LIBRARIES Qt5::Test KF5::WebEngineViewer
     )
 
-
-
-ecm_add_test(localdatabasemanagertest.cpp ../checkphishingurlutil.cpp ../updatedatabaseinfo.cpp ../localdatabasemanager.cpp ${testwebengineviewer_webengine_common_SRCS}
+ecm_add_test(localdatabasemanagertest.cpp ${testwebengineviewer_webengine_common_SRCS}
     TEST_NAME localdatabasemanagertest
     NAME_PREFIX "webengineview-"
     LINK_LIBRARIES Qt5::Test KF5::WebEngineViewer
     )
 
-ecm_add_test(searchfullhashjobtest.cpp ../checkphishingurlutil.cpp ../updatedatabaseinfo.cpp ../searchfullhashjob.cpp ${testwebengineviewer_webengine_common_SRCS}
+ecm_add_test(searchfullhashjobtest.cpp ${testwebengineviewer_webengine_common_SRCS}
     TEST_NAME searchfullhashjobtest
     NAME_PREFIX "webengineview-"
     LINK_LIBRARIES Qt5::Test KF5::WebEngineViewer

webengineviewer/src/checkphishingurl/checkphishingurlutil.h

@@ -21,7 +21,7 @@ enum UrlStatus {
 };
 
 QString apiKey();
-QString versionApps();
+WEBENGINEVIEWER_EXPORT QString versionApps();
 QString databaseFileName();
 WEBENGINEVIEWER_EXPORT QString configFileName();
 WEBENGINEVIEWER_EXPORT quint16 minorVersion();

webengineviewer/src/findbar/autotests/CMakeLists.txt

-ecm_add_test(findbarbasetest.cpp  ../findbarbase.cpp
+ecm_add_test(findbarbasetest.cpp
     TEST_NAME findbarbasetest
     NAME_PREFIX "webengineviewer-findbar-"
-    LINK_LIBRARIES Qt5::Test Qt5::Widgets Qt5::Gui KF5::Completion KF5::I18n KF5::ConfigWidgets KF5::PimCommon
+    LINK_LIBRARIES KF5WebEngineViewer Qt5::Test Qt5::Widgets Qt5::Gui KF5::Completion KF5::I18n KF5::ConfigWidgets KF5::PimCommon
 )
 set_property(TARGET findbarbasetest PROPERTY INCLUDE_DIRECTORIES ${CMAKE_SOURCE_DIR}/webengineviewer ${CMAKE_BINARY_DIR}/webengineviewer/src)