Commit f8de333a authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

const'ify pointer + add missing override

parent a04975b2
Pipeline #48359 failed with stage
in 25 minutes and 25 seconds
......@@ -37,7 +37,6 @@ static const int gHorizontalItemSpacing = 2;
ThemeDelegate::ThemeDelegate(QAbstractItemView *parent)
: QStyledItemDelegate(parent)
, mTheme(nullptr)
{
mItemView = parent;
}
......
......@@ -39,7 +39,7 @@ public:
void generalFontChanged();
private:
const Theme *mTheme; ///< Shallow pointer to the current theme
const Theme *mTheme = nullptr; ///< Shallow pointer to the current theme
QAbstractItemView *mItemView = nullptr;
QColor mGroupHeaderBackgroundColor; // cache
......
......@@ -45,10 +45,6 @@ QDataStream &operator>>(QDataStream &stream, CacheHeader &header)
}
ThreadingCache::ThreadingCache()
: mGrouping(Aggregation::NoGrouping)
, mThreading(Aggregation::NoThreading)
, mThreadLeader(Aggregation::TopmostMessage)
, mEnabled(true)
{
}
......
......@@ -41,10 +41,10 @@ private:
QHash<qint64 /* ID */, MessageItem *> mItemCache;
QString mCacheId;
Aggregation::Grouping mGrouping;
Aggregation::Threading mThreading;
Aggregation::ThreadLeader mThreadLeader;
bool mEnabled;
Aggregation::Grouping mGrouping = Aggregation::NoGrouping;
Aggregation::Threading mThreading = Aggregation::NoThreading;
Aggregation::ThreadLeader mThreadLeader = Aggregation::TopmostMessage;
bool mEnabled = true;
};
} // namespace Core
} // namespace MessageList
......
......@@ -19,7 +19,6 @@ class MessageList::Utils::AggregationConfigButtonPrivate
public:
AggregationConfigButtonPrivate(AggregationConfigButton *owner)
: q(owner)
, mAggregationComboBox(nullptr)
{
}
......
......@@ -41,7 +41,7 @@ public:
mAggregation = new Core::Aggregation(set);
}
~AggregationListWidgetItem()
~AggregationListWidgetItem() override
{
delete mAggregation;
}
......
......@@ -39,7 +39,7 @@ public:
mTheme = new Core::Theme(set);
}
~ThemeListWidgetItem()
~ThemeListWidgetItem() override
{
delete mTheme;
}
......
......@@ -20,7 +20,6 @@ class MessageList::Utils::ThemeConfigButtonPrivate
public:
ThemeConfigButtonPrivate(ThemeConfigButton *owner)
: q(owner)
, mThemeComboBox(nullptr)
{
}
......
......@@ -42,7 +42,7 @@ public:
explicit ThemeColumnPropertiesDialog(QWidget *parent, Core::Theme::Column *column, const QString &title);
protected:
Core::Theme::Column *mColumn = nullptr;
Core::Theme::Column *const mColumn;
QLineEdit *mNameEdit = nullptr;
QCheckBox *mVisibleByDefaultCheck = nullptr;
QCheckBox *mIsSenderOrReceiverCheck = nullptr;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment