Commit 3a8d5e3f authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Add missing override + const'ify pointer

parent f22d259d
Pipeline #42082 passed with stage
in 11 minutes and 31 seconds
......@@ -27,7 +27,7 @@ class LIBSIEVEEDITOR_TESTS_EXPORT ImportImapSettingFinishPage : public QWidget
Q_OBJECT
public:
explicit ImportImapSettingFinishPage(QWidget *parent = nullptr);
~ImportImapSettingFinishPage();
~ImportImapSettingFinishPage() override;
void addSummary(const QString &name);
......
......@@ -28,7 +28,7 @@ class LIBSIEVEEDITOR_TESTS_EXPORT ImportImapSettingNoFoundPage : public QWidget
Q_OBJECT
public:
explicit ImportImapSettingNoFoundPage(QWidget *parent = nullptr);
~ImportImapSettingNoFoundPage();
~ImportImapSettingNoFoundPage() override;
};
#endif // IMPORTIMAPSETTINGNOFOUNDPAGE_H
......@@ -29,7 +29,7 @@ class LIBSIEVEEDITOR_TESTS_EXPORT ImportImapSettingSearchPage : public QWidget
Q_OBJECT
public:
explicit ImportImapSettingSearchPage(QWidget *parent = nullptr);
~ImportImapSettingSearchPage();
~ImportImapSettingSearchPage() override;
void setProgramList(const QStringList &lst);
Q_REQUIRED_RESULT QStringList selectedPrograms() const;
......
......@@ -27,7 +27,7 @@ class ServerSieveListWidgetItem : public QListWidgetItem
{
public:
explicit ServerSieveListWidgetItem(QListWidget *parent = nullptr);
~ServerSieveListWidgetItem();
~ServerSieveListWidgetItem() override;
Q_REQUIRED_RESULT SieveEditorUtil::SieveServerConfig serverConfig() const;
void setServerConfig(const SieveEditorUtil::SieveServerConfig &conf);
......@@ -41,7 +41,7 @@ class ServerSieveListWidget : public QListWidget
Q_OBJECT
public:
explicit ServerSieveListWidget(QWidget *parent = nullptr);
~ServerSieveListWidget();
~ServerSieveListWidget() override;
void readConfig();
void writeConfig();
......
......@@ -29,7 +29,7 @@ class ServerSieveSettingsDialog : public QDialog
Q_OBJECT
public:
explicit ServerSieveSettingsDialog(QWidget *parent = nullptr);
~ServerSieveSettingsDialog();
~ServerSieveSettingsDialog() override;
Q_REQUIRED_RESULT QString serverName() const;
void setServerName(const QString &name);
......
......@@ -34,7 +34,7 @@ class SieveEditorConfigureDialog : public KPageDialog
Q_OBJECT
public:
explicit SieveEditorConfigureDialog(QWidget *parent = nullptr);
~SieveEditorConfigureDialog();
~SieveEditorConfigureDialog() override;
void saveServerSieveConfig();
......
......@@ -28,7 +28,7 @@ class LIBSIEVEEDITOR_TESTS_EXPORT SieveEditorConfigureServerPage : public QWidge
Q_OBJECT
public:
explicit SieveEditorConfigureServerPage(QWidget *parent = nullptr);
~SieveEditorConfigureServerPage();
~SieveEditorConfigureServerPage() override;
Q_SIGNALS:
void configureClicked();
......
......@@ -48,7 +48,7 @@ class SieveEditorEmptyTabWidgetLabel : public QLabel
Q_OBJECT
public:
explicit SieveEditorEmptyTabWidgetLabel(QWidget *parent = nullptr);
~SieveEditorEmptyTabWidgetLabel();
~SieveEditorEmptyTabWidgetLabel() override;
private:
struct placeHolderTextInfo {
......
......@@ -35,7 +35,7 @@ class SieveEditorPageWidget : public QWidget
Q_OBJECT
public:
explicit SieveEditorPageWidget(QWidget *parent = nullptr);
~SieveEditorPageWidget();
~SieveEditorPageWidget() override;
void loadScript(const KSieveUi::ManageSieveWidget::ScriptInfo &info);
Q_REQUIRED_RESULT QUrl currentUrl() const;
......
......@@ -19,6 +19,8 @@
#include "sieveeditorsavepasswordjob.h"
#include "sieveeditor_debug.h"
#include <qt5keychain/keychain.h>
using namespace QKeychain;
SieveEditorSavePasswordJob::SieveEditorSavePasswordJob(QObject *parent)
......
......@@ -22,13 +22,15 @@
#include <QObject>
#include "libsieveeditor_export.h"
#include <qt5keychain/keychain.h>
namespace QKeychain {
class Job;
}
class LIBSIEVEEDITOR_EXPORT SieveEditorSavePasswordJob : public QObject
{
Q_OBJECT
public:
explicit SieveEditorSavePasswordJob(QObject *parent = nullptr);
~SieveEditorSavePasswordJob();
~SieveEditorSavePasswordJob() override;
Q_REQUIRED_RESULT bool canStart() const;
......
......@@ -33,7 +33,7 @@ class SieveEditorScriptManagerWidget : public QWidget
Q_OBJECT
public:
explicit SieveEditorScriptManagerWidget(QWidget *parent = nullptr);
~SieveEditorScriptManagerWidget();
~SieveEditorScriptManagerWidget() override;
void updateServerList();
void editScript();
......
......@@ -26,7 +26,7 @@ class SieveEditorTabWidget : public QTabWidget
Q_OBJECT
public:
explicit SieveEditorTabWidget(KActionCollection *ac, QWidget *parent = nullptr);
~SieveEditorTabWidget();
~SieveEditorTabWidget() override;
Q_SIGNALS:
void tabRemoveAllExclude(int index);
......
......@@ -29,8 +29,8 @@
UserFeedBackManager::UserFeedBackManager(QObject *parent)
: QObject(parent)
, mUserFeedbackProvider(new KUserFeedback::Provider(this))
{
mUserFeedbackProvider = new KUserFeedback::Provider(this);
mUserFeedbackProvider->setProductIdentifier(QStringLiteral("org.kde.pim-sieve-editor"));
mUserFeedbackProvider->setFeedbackServer(QUrl(QStringLiteral("https://telemetry.kde.org/")));
mUserFeedbackProvider->setSubmissionInterval(7);
......
......@@ -35,7 +35,7 @@ public:
KUserFeedback::Provider *userFeedbackProvider() const;
private:
KUserFeedback::Provider *mUserFeedbackProvider = nullptr;
KUserFeedback::Provider *const mUserFeedbackProvider;
};
#endif // USERFEEDBACKMANAGER_H
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment