Modernize code

src/pimcommon/autocorrection/autocorrectionwidget.cpp

@@ -112,7 +112,7 @@ AutoCorrectionWidget::AutoCorrectionWidget(QWidget *parent)
     slotEnableDisableAbreviationList();
     slotEnableDisableTwoUpperEntry();
 
-    QMenu *menu = new QMenu(this);
+    auto *menu = new QMenu(this);
     d->ui->importAutoCorrection->setMenu(menu);
 
     QAction *act = new QAction(i18n("LibreOffice Autocorrection"), this);
@@ -547,7 +547,7 @@ void AutoCorrectionWidget::slotEnableDisableTwoUpperEntry()
 void AutoCorrectionWidget::slotImportAutoCorrection(QAction *act)
 {
     if (act) {
-        AutoCorrectionWidget::ImportFileType type = act->data().value<AutoCorrectionWidget::ImportFileType>();
+        auto type = act->data().value<AutoCorrectionWidget::ImportFileType>();
         QString title;
         QString filter;
         switch (type) {

src/pimcommon/autocorrection/import/importlibreofficeautocorrection.cpp

@@ -91,7 +91,7 @@ bool ImportLibreOfficeAutocorrection::importFile(Type type, const KArchiveDirect
     }
     documentList = archiveDirectory->entry(archiveFileName);
     if (documentList && documentList->isFile()) {
-        const KArchiveFile *archiveFile = static_cast<const KArchiveFile *>(documentList);
+        const auto *archiveFile = static_cast<const KArchiveFile *>(documentList);
         archiveFile->copyTo(mTempDir->path());
         QFile file(mTempDir->path() + QLatin1Char('/') + archiveFileName);
         QDomDocument doc;

src/pimcommon/autocorrection/tests/autocorrection_gui.cpp

@@ -26,7 +26,7 @@ ConfigureTestDialog::ConfigureTestDialog(PimCommon::AutoCorrection *autoCorrecti
     : QDialog(parent)
 {
     setWindowTitle(QStringLiteral("Configure Autocorrection"));
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
+    auto *mainLayout = new QVBoxLayout(this);
     QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this);
     QPushButton *okButton = buttonBox->button(QDialogButtonBox::Ok);
     okButton->setDefault(true);
@@ -92,8 +92,8 @@ AutocorrectionTestWidget::AutocorrectionTestWidget(QWidget *parent)
     PimCommon::PimCommonSettings::self()->load();
 
     mAutoCorrection = new PimCommon::AutoCorrection;
-    QVBoxLayout *lay = new QVBoxLayout(this);
-    QToolBar *bar = new QToolBar;
+    auto *lay = new QVBoxLayout(this);
+    auto *bar = new QToolBar;
     lay->addWidget(bar);
     bar->addAction(QStringLiteral("Configure..."), this, &AutocorrectionTestWidget::slotConfigure);
     QAction *richText = new QAction(QStringLiteral("HTML mode"), this);
@@ -138,7 +138,7 @@ int main(int argc, char **argv)
     parser.addHelpOption();
     parser.process(app);
 
-    AutocorrectionTestWidget *w = new AutocorrectionTestWidget();
+    auto *w = new AutocorrectionTestWidget();
     w->resize(800, 600);
 
     w->show();

src/pimcommon/autocorrection/tests/richtexteditwithautocorrection_gui.cpp

@@ -21,7 +21,7 @@ int main(int argc, char **argv)
     parser.addHelpOption();
     parser.process(app);
 
-    PimCommon::RichTextEditWithAutoCorrection *w = new PimCommon::RichTextEditWithAutoCorrection;
+    auto *w = new PimCommon::RichTextEditWithAutoCorrection;
 
     w->show();
     app.exec();

src/pimcommon/configureplugins/autotests/configurepluginslistwidgettest.cpp

@@ -23,11 +23,11 @@ void ConfigurePluginsListWidgetTest::shouldHaveDefaultValue()
 {
     PimCommon::ConfigurePluginsListWidget w;
 
-    QVBoxLayout *mainLayout = w.findChild<QVBoxLayout *>(QStringLiteral("mainlayout"));
+    auto *mainLayout = w.findChild<QVBoxLayout *>(QStringLiteral("mainlayout"));
     QVERIFY(mainLayout);
     QCOMPARE(mainLayout->contentsMargins(), QMargins(0, 0, 0, 0));
 
-    QTreeWidget *mListWidget = w.findChild<QTreeWidget *>(QStringLiteral("listwidget"));
+    auto *mListWidget = w.findChild<QTreeWidget *>(QStringLiteral("listwidget"));
     QVERIFY(mListWidget);
     QVERIFY(mListWidget->isSortingEnabled());
 }

src/pimcommon/configureplugins/autotests/configurepluginswidgettest.cpp

@@ -27,19 +27,19 @@ void ConfigurePluginsWidgetTest::shouldHaveDefaultValue()
 {
     PimCommon::ConfigurePluginsWidget w;
 
-    KMessageWidget *mMessageWidget = w.findChild<KMessageWidget *>(QStringLiteral("mMessageWidget"));
+    auto *mMessageWidget = w.findChild<KMessageWidget *>(QStringLiteral("mMessageWidget"));
     QVERIFY(mMessageWidget);
     QVERIFY(!mMessageWidget->isCloseButtonVisible());
     QVERIFY(!mMessageWidget->text().isEmpty());
 
-    QSplitter *mSplitter = w.findChild<QSplitter *>(QStringLiteral("splitter"));
+    auto *mSplitter = w.findChild<QSplitter *>(QStringLiteral("splitter"));
     QVERIFY(mSplitter);
     QCOMPARE(mSplitter->count(), 2);
 
-    PimCommon::ConfigurePluginsListWidget *mConfigureListWidget = mSplitter->findChild<PimCommon::ConfigurePluginsListWidget *>(QStringLiteral("configureListWidget"));
+    auto *mConfigureListWidget = mSplitter->findChild<PimCommon::ConfigurePluginsListWidget *>(QStringLiteral("configureListWidget"));
     QVERIFY(mConfigureListWidget);
 
-    QTextEdit *mDescription = mSplitter->findChild<QTextEdit *>(QStringLiteral("description"));
+    auto *mDescription = mSplitter->findChild<QTextEdit *>(QStringLiteral("description"));
     QVERIFY(mDescription);
     QVERIFY(mDescription->isReadOnly());
     QVERIFY(mDescription->document()->isEmpty());

src/pimcommon/configureplugins/configureplugindialog.cpp

@@ -26,7 +26,7 @@ ConfigurePluginDialog::~ConfigurePluginDialog()
 
 void ConfigurePluginDialog::initLayout(bool addSpacer)
 {
-    QVBoxLayout *layout = new QVBoxLayout(this);
+    auto *layout = new QVBoxLayout(this);
     layout->addWidget(createLayout());
     if (addSpacer) {
         layout->addStretch(1);

src/pimcommon/configureplugins/configurepluginslistwidget.cpp

@@ -20,7 +20,7 @@ using namespace PimCommon;
 ConfigurePluginsListWidget::ConfigurePluginsListWidget(QWidget *parent)
     : QWidget(parent)
 {
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
+    auto *mainLayout = new QVBoxLayout(this);
     mainLayout->setObjectName(QStringLiteral("mainlayout"));
     mainLayout->setContentsMargins(0, 0, 0, 0);
 
@@ -56,7 +56,7 @@ void ConfigurePluginsListWidget::slotItemChanged(QTreeWidgetItem *item, int colu
 void ConfigurePluginsListWidget::slotItemSelectionChanged()
 {
     QTreeWidgetItem *item = mListWidget->currentItem();
-    if (PluginItem *pluginItem = dynamic_cast<PluginItem *>(item)) {
+    if (auto *pluginItem = dynamic_cast<PluginItem *>(item)) {
         Q_EMIT descriptionChanged(pluginItem->mDescription);
     }
 }
@@ -115,7 +115,7 @@ void ConfigurePluginsListWidget::fillTopItems(const QVector<PimCommon::PluginUti
         topLevel->setFlags(topLevel->flags() & ~Qt::ItemIsSelectable);
         const QPair<QStringList, QStringList> pair = PimCommon::PluginUtil::loadPluginSetting(groupName, prefixKey);
         for (const PimCommon::PluginUtilData &data : lst) {
-            PluginItem *subItem = new PluginItem(topLevel);
+            auto *subItem = new PluginItem(topLevel);
             subItem->setText(0, data.mName);
             subItem->mIdentifier = data.mIdentifier;
             subItem->mDescription = data.mDescription;
@@ -127,8 +127,8 @@ void ConfigurePluginsListWidget::fillTopItems(const QVector<PimCommon::PluginUti
                 subItem->setCheckState(0, isPluginActivated ? Qt::Checked : Qt::Unchecked);
             }
             if (data.mHasConfigureDialog) {
-                QToolButton *but = new QToolButton(mListWidget);
-                QAction *act = new QAction(but);
+                auto *but = new QToolButton(mListWidget);
+                auto *act = new QAction(but);
                 const QStringList actData {
                     configureGroupName, data.mIdentifier
                 };

src/pimcommon/configureplugins/configurepluginswidget.cpp

@@ -37,7 +37,7 @@ ConfigurePluginsWidget::~ConfigurePluginsWidget()
 
 void ConfigurePluginsWidget::initLayout(ConfigurePluginsListWidget *configurePluginListWidget)
 {
-    QVBoxLayout *layout = new QVBoxLayout(this);
+    auto *layout = new QVBoxLayout(this);
     layout->setContentsMargins(0, 0, 0, 0);
 
     mMessageWidget = new KMessageWidget(i18n("Restart is necessary for applying the changes."), this);

src/pimcommon/customtools/autotests/customtoolswidgetngtest.cpp

@@ -25,7 +25,7 @@ void CustomToolsWidgetNgTest::shouldHaveDefaultValue()
     PimCommon::CustomToolsWidgetNg widget;
     widget.show();
 
-    QStackedWidget *stackWidget = widget.findChild<QStackedWidget *>(QStringLiteral("stackedwidget"));
+    auto *stackWidget = widget.findChild<QStackedWidget *>(QStringLiteral("stackedwidget"));
     QVERIFY(stackWidget);
 }
 

src/pimcommon/customtools/customtoolswidgetng.cpp

@@ -31,7 +31,7 @@ CustomToolsWidgetNg::CustomToolsWidgetNg(QWidget *parent)
     : QWidget(parent)
     , d(new PimCommon::CustomToolsWidgetNgPrivate)
 {
-    QHBoxLayout *lay = new QHBoxLayout(this);
+    auto *lay = new QHBoxLayout(this);
     d->mStackedWidget = new QStackedWidget;
     d->mStackedWidget->setObjectName(QStringLiteral("stackedwidget"));
     lay->addWidget(d->mStackedWidget);

src/pimcommon/genericplugins/autotests/actiontypetest.cpp

@@ -27,7 +27,7 @@ void ActionTypeTest::shouldHaveDefaultValue()
 
 void ActionTypeTest::shouldAssignValue()
 {
-    QAction *act = new QAction(nullptr);
+    auto *act = new QAction(nullptr);
     PimCommon::ActionType::Type type = PimCommon::ActionType::File;
     PimCommon::ActionType actionType(act, type);
     QCOMPARE(actionType.action(), act);

src/pimcommon/logactivities/autotests/logactivitiesdialogtest.cpp

@@ -30,18 +30,18 @@ LogActivitiesDialogTest::~LogActivitiesDialogTest()
 void LogActivitiesDialogTest::shouldHaveDefaultValue()
 {
     PimCommon::LogActivitiesDialog w;
-    QVBoxLayout *mainLayout = w.findChild<QVBoxLayout *>(QStringLiteral("mainLayout"));
+    auto *mainLayout = w.findChild<QVBoxLayout *>(QStringLiteral("mainLayout"));
     QVERIFY(mainLayout);
 
-    PimCommon::LogActivitiesWidget *mLogWidget = w.findChild<PimCommon::LogActivitiesWidget *>(QStringLiteral("logwidget"));
+    auto *mLogWidget = w.findChild<PimCommon::LogActivitiesWidget *>(QStringLiteral("logwidget"));
     QVERIFY(mLogWidget);
 
-    QCheckBox *mEnableLogActivities = w.findChild<QCheckBox *>(QStringLiteral("enablelogactivities"));
+    auto *mEnableLogActivities = w.findChild<QCheckBox *>(QStringLiteral("enablelogactivities"));
     QVERIFY(mEnableLogActivities);
     QVERIFY(!mEnableLogActivities->text().isEmpty());
     QVERIFY(!mEnableLogActivities->isChecked());
 
-    QDialogButtonBox *buttonBox = w.findChild<QDialogButtonBox *>(QStringLiteral("buttonbox"));
+    auto *buttonBox = w.findChild<QDialogButtonBox *>(QStringLiteral("buttonbox"));
     QVERIFY(buttonBox);
 
     const QList<QAbstractButton *> lstButtonBox = buttonBox->buttons();
@@ -60,9 +60,9 @@ void LogActivitiesDialogTest::shouldHaveDefaultValue()
 void LogActivitiesDialogTest::shouldClearLog()
 {
     PimCommon::LogActivitiesDialog w;
-    QDialogButtonBox *buttonBox = w.findChild<QDialogButtonBox *>(QStringLiteral("buttonbox"));
+    auto *buttonBox = w.findChild<QDialogButtonBox *>(QStringLiteral("buttonbox"));
 
-    PimCommon::LogActivitiesWidget *mLogWidget = w.findChild<PimCommon::LogActivitiesWidget *>(QStringLiteral("logwidget"));
+    auto *mLogWidget = w.findChild<PimCommon::LogActivitiesWidget *>(QStringLiteral("logwidget"));
 
     QVERIFY(mLogWidget->log().isEmpty());
 
@@ -87,7 +87,7 @@ void LogActivitiesDialogTest::shouldHaveCorrectLogActivities()
 {
     PimCommon::LogActivitiesManager::self()->setEnableLogActivities(true);
     PimCommon::LogActivitiesDialog w;
-    QCheckBox *mEnableLogActivities = w.findChild<QCheckBox *>(QStringLiteral("enablelogactivities"));
+    auto *mEnableLogActivities = w.findChild<QCheckBox *>(QStringLiteral("enablelogactivities"));
     QVERIFY(mEnableLogActivities->isChecked());
 }
 

src/pimcommon/logactivities/autotests/logactivitieswidgettest.cpp

@@ -22,11 +22,11 @@ LogActivitiesWidgetTest::~LogActivitiesWidgetTest()
 void LogActivitiesWidgetTest::shouldHaveDefaultValue()
 {
     PimCommon::LogActivitiesWidget w;
-    QVBoxLayout *mainLayout = w.findChild<QVBoxLayout *>(QStringLiteral("mainLayout"));
+    auto *mainLayout = w.findChild<QVBoxLayout *>(QStringLiteral("mainLayout"));
     QVERIFY(mainLayout);
     QCOMPARE(mainLayout->contentsMargins(), QMargins(0, 0, 0, 0));
 
-    KPIMTextEdit::PlainTextEditorWidget *mLog = w.findChild<KPIMTextEdit::PlainTextEditorWidget *>(QStringLiteral("log"));
+    auto *mLog = w.findChild<KPIMTextEdit::PlainTextEditorWidget *>(QStringLiteral("log"));
     QVERIFY(mLog);
     QVERIFY(mLog->isReadOnly());
 }

src/pimcommon/logactivities/logactivitiesdialog.cpp

@@ -23,7 +23,7 @@ LogActivitiesDialog::LogActivitiesDialog(QWidget *parent)
     : QDialog(parent)
 {
     setWindowTitle(i18nc("@title:window", "Log activities"));
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
+    auto *mainLayout = new QVBoxLayout(this);
     mainLayout->setObjectName(QStringLiteral("mainLayout"));
 
     mLogWidget = new LogActivitiesWidget(this);
@@ -46,7 +46,7 @@ LogActivitiesDialog::LogActivitiesDialog(QWidget *parent)
     mSaveButton->setObjectName(QStringLiteral("savebutton"));
     mSaveButton->setEnabled(false);
 
-    LogactivitiesPurposeMenuWidget *purposeMenu = new LogactivitiesPurposeMenuWidget(this, this);
+    auto *purposeMenu = new LogactivitiesPurposeMenuWidget(this, this);
     mShareButton = new QPushButton(i18n("Share..."), this);
     mShareButton->setMenu(purposeMenu->menu());
     mShareButton->setIcon(QIcon::fromTheme(QStringLiteral("document-share")));

src/pimcommon/logactivities/logactivitieswidget.cpp

@@ -13,7 +13,7 @@ using namespace PimCommon;
 LogActivitiesWidget::LogActivitiesWidget(QWidget *parent)
     : QWidget(parent)
 {
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
+    auto *mainLayout = new QVBoxLayout(this);
     mainLayout->setContentsMargins(0, 0, 0, 0);
     mainLayout->setObjectName(QStringLiteral("mainLayout"));
 

src/pimcommon/logactivities/tests/logactivitiesmainwidget.cpp

@@ -14,7 +14,7 @@
 LogActivitiesMainWidget::LogActivitiesMainWidget(QWidget *parent)
     : QWidget(parent)
 {
-    QHBoxLayout *mainLayout = new QHBoxLayout(this);
+    auto *mainLayout = new QHBoxLayout(this);
     QPushButton *button = new QPushButton(QStringLiteral("Open Log"), this);
     connect(button, &QPushButton::clicked, this, &LogActivitiesMainWidget::slotOpenDialog);
     mainLayout->addWidget(button);

src/pimcommon/logactivities/tests/main.cpp

@@ -19,7 +19,7 @@ int main(int argc, char **argv)
 
     parser.process(app);
 
-    LogActivitiesMainWidget *w = new LogActivitiesMainWidget;
+    auto *w = new LogActivitiesMainWidget;
     w->show();
     app.exec();
     return 0;

src/pimcommon/shareserviceurl/shareserviceurlmanager.cpp

@@ -34,7 +34,7 @@ void ShareServiceUrlManagerPrivate::initializeMenu()
 {
     mMenu = new KActionMenu(QIcon::fromTheme(QStringLiteral("document-share")), i18n("Share On..."), q);
     for (int i = 0; i < ShareServiceUrlManager::ServiceEndType; ++i) {
-        const ShareServiceUrlManager::ServiceType type = static_cast<ShareServiceUrlManager::ServiceType>(i);
+        const auto type = static_cast<ShareServiceUrlManager::ServiceType>(i);
         QAction *action = new QAction(i18nc("@action:inmenu Share On...", "%1", typeToI18n(type)), q);
         action->setData(QVariant::fromValue(type));
         const QIcon icon = typeToIcon(type);
@@ -127,7 +127,7 @@ KActionMenu *ShareServiceUrlManager::menu() const
 void ShareServiceUrlManager::slotSelectServiceUrl(QAction *act)
 {
     if (act) {
-        const ServiceType type = act->data().value<PimCommon::ShareServiceUrlManager::ServiceType>();
+        const auto type = act->data().value<PimCommon::ShareServiceUrlManager::ServiceType>();
         Q_EMIT serviceUrlSelected(type);
     }
 }

src/pimcommon/templatewidgets/templateeditdialog.cpp

@@ -26,7 +26,7 @@ TemplateEditDialog::TemplateEditDialog(QWidget *parent, bool defaultTemplate)
     : QDialog(parent)
 {
     setWindowTitle(defaultTemplate ? i18n("Default template") : i18n("Template"));
-    QVBoxLayout *mainLayout = new QVBoxLayout(this);
+    auto *mainLayout = new QVBoxLayout(this);
     QDialogButtonBox *buttonBox = nullptr;
     if (defaultTemplate) {
         buttonBox = new QDialogButtonBox(QDialogButtonBox::Close, this);
@@ -44,10 +44,10 @@ TemplateEditDialog::TemplateEditDialog(QWidget *parent, bool defaultTemplate)
     mainLayout->addWidget(w);
     mainLayout->addWidget(buttonBox);
 
-    QVBoxLayout *vbox = new QVBoxLayout;
+    auto *vbox = new QVBoxLayout;
     vbox->setContentsMargins(0, 0, 0, 0);
 
-    QHBoxLayout *hbox = new QHBoxLayout;
+    auto *hbox = new QHBoxLayout;
     QLabel *label = new QLabel(i18n("Name:"));
     hbox->addWidget(label);