Commit f6558301 authored by Laurent Montel's avatar Laurent Montel 😁

Clean up code

parent 13efb8d9
Pipeline #32060 passed with stage
in 18 minutes and 12 seconds
......@@ -10,7 +10,6 @@ using namespace PimCommon;
AbstractGenericPlugin::AbstractGenericPlugin(QObject *parent)
: QObject(parent)
, mIsEnabled(true)
{
}
......
......@@ -37,7 +37,7 @@ Q_SIGNALS:
void configChanged();
private:
bool mIsEnabled;
bool mIsEnabled = true;
};
}
#endif // AbstractGENERICPLUGIN_H
......@@ -17,8 +17,7 @@ class PimCommon::LogActivitiesManagerPrivate
{
public:
LogActivitiesManagerPrivate()
: mDialog{nullptr}
, mEnableLogActivities{false}
: mDialog(nullptr)
{
}
......
......@@ -23,8 +23,8 @@ public:
{
}
QIcon typeToIcon(ShareServiceUrlManager::ServiceType type) const;
QString typeToI18n(ShareServiceUrlManager::ServiceType type) const;
Q_REQUIRED_RESULT QIcon typeToIcon(ShareServiceUrlManager::ServiceType type) const;
Q_REQUIRED_RESULT QString typeToI18n(ShareServiceUrlManager::ServiceType type) const;
void initializeMenu();
KActionMenu *mMenu = nullptr;
ShareServiceUrlManager *const q;
......
......@@ -27,8 +27,7 @@ class TemplateListWidgetPrivate
{
public:
TemplateListWidgetPrivate(const QString &configName, TemplateListWidget *qq)
: dirty(false)
, config(KSharedConfig::openConfig(configName, KConfig::NoGlobals))
: config(KSharedConfig::openConfig(configName, KConfig::NoGlobals))
, q(qq)
{
}
......@@ -278,7 +277,7 @@ public:
}
QString knewstuffConfigName;
bool dirty;
bool dirty =false;
KSharedConfig::Ptr config;
TemplateListWidget * const q;
};
......
......@@ -14,7 +14,6 @@ using namespace PimCommon;
CustomTreeView::CustomTreeView(QWidget *parent)
: QTreeWidget(parent)
, mShowDefaultText(true)
{
}
......
......@@ -37,7 +37,7 @@ protected:
void changeEvent(QEvent *event) override;
protected:
bool mShowDefaultText;
bool mShowDefaultText = true;
private:
QColor mTextColor;
......
......@@ -33,7 +33,7 @@ private:
void slotShareActionFinished(const QJsonObject &output, int error, const QString &message);
Purpose::Menu *mShareMenu = nullptr;
QTemporaryFile *mTemporaryShareFile = nullptr;
QWidget *mParentWidget = nullptr;
QWidget *const mParentWidget;
};
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment