Commit f6558301 authored by Laurent Montel's avatar Laurent Montel 😁

Clean up code

parent 13efb8d9
Pipeline #32060 passed with stage
in 18 minutes and 12 seconds
...@@ -10,7 +10,6 @@ using namespace PimCommon; ...@@ -10,7 +10,6 @@ using namespace PimCommon;
AbstractGenericPlugin::AbstractGenericPlugin(QObject *parent) AbstractGenericPlugin::AbstractGenericPlugin(QObject *parent)
: QObject(parent) : QObject(parent)
, mIsEnabled(true)
{ {
} }
......
...@@ -37,7 +37,7 @@ Q_SIGNALS: ...@@ -37,7 +37,7 @@ Q_SIGNALS:
void configChanged(); void configChanged();
private: private:
bool mIsEnabled; bool mIsEnabled = true;
}; };
} }
#endif // AbstractGENERICPLUGIN_H #endif // AbstractGENERICPLUGIN_H
...@@ -17,8 +17,7 @@ class PimCommon::LogActivitiesManagerPrivate ...@@ -17,8 +17,7 @@ class PimCommon::LogActivitiesManagerPrivate
{ {
public: public:
LogActivitiesManagerPrivate() LogActivitiesManagerPrivate()
: mDialog{nullptr} : mDialog(nullptr)
, mEnableLogActivities{false}
{ {
} }
......
...@@ -23,8 +23,8 @@ public: ...@@ -23,8 +23,8 @@ public:
{ {
} }
QIcon typeToIcon(ShareServiceUrlManager::ServiceType type) const; Q_REQUIRED_RESULT QIcon typeToIcon(ShareServiceUrlManager::ServiceType type) const;
QString typeToI18n(ShareServiceUrlManager::ServiceType type) const; Q_REQUIRED_RESULT QString typeToI18n(ShareServiceUrlManager::ServiceType type) const;
void initializeMenu(); void initializeMenu();
KActionMenu *mMenu = nullptr; KActionMenu *mMenu = nullptr;
ShareServiceUrlManager *const q; ShareServiceUrlManager *const q;
......
...@@ -27,8 +27,7 @@ class TemplateListWidgetPrivate ...@@ -27,8 +27,7 @@ class TemplateListWidgetPrivate
{ {
public: public:
TemplateListWidgetPrivate(const QString &configName, TemplateListWidget *qq) TemplateListWidgetPrivate(const QString &configName, TemplateListWidget *qq)
: dirty(false) : config(KSharedConfig::openConfig(configName, KConfig::NoGlobals))
, config(KSharedConfig::openConfig(configName, KConfig::NoGlobals))
, q(qq) , q(qq)
{ {
} }
...@@ -278,7 +277,7 @@ public: ...@@ -278,7 +277,7 @@ public:
} }
QString knewstuffConfigName; QString knewstuffConfigName;
bool dirty; bool dirty =false;
KSharedConfig::Ptr config; KSharedConfig::Ptr config;
TemplateListWidget * const q; TemplateListWidget * const q;
}; };
......
...@@ -14,7 +14,6 @@ using namespace PimCommon; ...@@ -14,7 +14,6 @@ using namespace PimCommon;
CustomTreeView::CustomTreeView(QWidget *parent) CustomTreeView::CustomTreeView(QWidget *parent)
: QTreeWidget(parent) : QTreeWidget(parent)
, mShowDefaultText(true)
{ {
} }
......
...@@ -37,7 +37,7 @@ protected: ...@@ -37,7 +37,7 @@ protected:
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
protected: protected:
bool mShowDefaultText; bool mShowDefaultText = true;
private: private:
QColor mTextColor; QColor mTextColor;
......
...@@ -33,7 +33,7 @@ private: ...@@ -33,7 +33,7 @@ private:
void slotShareActionFinished(const QJsonObject &output, int error, const QString &message); void slotShareActionFinished(const QJsonObject &output, int error, const QString &message);
Purpose::Menu *mShareMenu = nullptr; Purpose::Menu *mShareMenu = nullptr;
QTemporaryFile *mTemporaryShareFile = nullptr; QTemporaryFile *mTemporaryShareFile = nullptr;
QWidget *mParentWidget = nullptr; QWidget *const mParentWidget;
}; };
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment