1. 05 Aug, 2020 2 commits
  2. 02 Aug, 2020 2 commits
  3. 19 Jul, 2020 1 commit
  4. 23 Jun, 2020 1 commit
  5. 20 Jun, 2020 1 commit
  6. 18 Jun, 2020 2 commits
  7. 17 Jun, 2020 3 commits
  8. 16 Jun, 2020 2 commits
  9. 15 Apr, 2020 1 commit
  10. 11 Apr, 2020 8 commits
  11. 04 Apr, 2020 1 commit
  12. 19 Mar, 2020 2 commits
  13. 13 Feb, 2020 2 commits
  14. 12 Feb, 2020 2 commits
  15. 20 Jan, 2020 3 commits
    • Ahmad Samir's avatar
      Make QRegularExpression filtering actually case-insensitive · f7e109f2
      Ahmad Samir authored
      Summary:
      I wrongly thought QSFPM::setFilterCaseSensitivity() would work when a
      QRegularExpression was used, but that method only pertains to QRegExp.
      Instead to get case-insensitive filtering set QRegularExpression::CaseInsensitiveOption
      on the QRegularExpression object used with setFilterRegularExpression().
      
      Also, thinking about this some more, no need to use QRegularExpression::escape()
      with the QuickSelectDialog since only (\w| ) are accepted by the dialog,
      everything else is gobbled up by the eventFilter().
      
      Test Plan:
      make && ctest, all unit tests pass except for:
      tests-units-akonadi-akonadistoragetest
      tests-units-akonadi-akonadicachingstorageintegrationtest
      tests-units-migrator-zanshin021migrationtest
      tests-units-migrator-zanshincontextitemsmigrationtest
      
      which fail locally but not on the CI.
      
      Reviewers: ervin
      
      Reviewed By: ervin
      
      Differential Revision: https://phabricator.kde.org/D26795
      f7e109f2
    • Ahmad Samir's avatar
      Port QRegExp to QRegularExpression · f0ff160b
      Ahmad Samir authored
      Summary:
      QSortFilterProxyModel::setFilterFixedString() internally uses QRegExp
      with QRegExp::FixedString syntax option; setFilterFixedString() was
      ported by using setFilterRegularExpression(QRegularExpression::escape(string)),
      this isn't perfect since QRegularExpression::escape() follows Perl quotemeta
      algorithm, basically it escapes all characters in the pattern except for [A-Z],
      [a-z], [0-9] and _; so for example a space ' ' is escaped too. See QRegularExpression
      docs for the details.
      
      Replace QSortFilterProxyModel::filterRegExp() with filterRegularExpression(),
      the same for the relevant setters. Raise min. required Qt version to 5.12,
      as that is where filterRegularExpression() was introduced.
      
      Test Plan: make && ctest; some unit tests fail but they fail on master too.
      
      Reviewers: ervin
      
      Reviewed By: ervin
      
      Differential Revision: https://phabricator.kde.org/D26567
      f0ff160b
    • Ahmad Samir's avatar
      Port KRecursiveFilterProxyModel to QSortFilterProxyModel · cb1e5e36
      Ahmad Samir authored
      Summary:
      Set setRecursiveFilteringEnabled(true) by default. Set required Qt
      version to 5.10.0, that's where QSortFilterProxyModel gained recursive
      filtering capability.
      
      Test Plan:
      make && ctest. All unit tests pass except for a couple of them, but
      these same ones fail on master too.
      
      Reviewers: ervin
      
      Reviewed By: ervin
      
      Maniphest Tasks: T12269
      
      Differential Revision: https://phabricator.kde.org/D26562
      cb1e5e36
  16. 17 Jan, 2020 1 commit
  17. 15 Jan, 2020 1 commit
  18. 08 Dec, 2019 2 commits
  19. 03 Dec, 2019 1 commit
  20. 23 Nov, 2019 1 commit
    • David Faure's avatar
      Port all of inboxpagemodeltest away from mocks · a3e40c72
      David Faure authored
      Summary:
      * Had to extend error handling in akonadifakestorage
      
      * There is something nasty with the kjobs being triggered for extra
      info, from *PageModel::data(). If they keep running past the end
      of the test method, they end up calling into a deleted Domain::LiveQueryInput.
      This is because JobHandlerInstance is a singleton so it stays around,
      the job's signal calls the JobHandlerInstance slot, and from there it's all
      about lambdas in deleted objects.
      Calling waitForEmptyJobQueue() at the right places avoids this, but it's
      still unexpected.
      
      * I wanted to skip fetching extra info when role == ObjectRole
      (we don't need it for that), but this only triggers the above problem
      even more, now it's later calls to data() which fetch extra info,
      increasing chances of jobs lying around after deletion of everything
      else.
      
      Test Plan: Tests pass
      
      Reviewers: ervin
      
      Reviewed By: ervin
      
      Differential Revision: https://phabricator.kde.org/D24282
      a3e40c72
  21. 27 Oct, 2019 1 commit