Add more tests

autotests/CMakeLists.txt

@@ -6,4 +6,15 @@ include_directories(../src)
 
 ecm_add_test(urlmodeltest.cpp ../src/urlmodel.cpp
              TEST_NAME urlmodeltest
-             LINK_LIBRARIES Qt5::Test )
+             LINK_LIBRARIES Qt5::Test
+)
+
+ecm_add_test(useragenttest.cpp ../src/useragent.cpp
+             TEST_NAME useragenttest
+             LINK_LIBRARIES Qt5::Test
+)
+
+ecm_add_test(browsermanagertest.cpp ../src/browsermanager.cpp ../src/urlmodel.cpp
+             TEST_NAME browsermanagertest
+             LINK_LIBRARIES Qt5::Test Qt5::Qml
+)

autotests/browsermanagertest.cpp

+/*
+ *  Copyright 2019 Jonah Brüchert <jbb@kaidan.im>
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Library General Public
+ *  License version 2 as published by the Free Software Foundation;
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Library General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Library General Public License
+ *  along with this library; see the file COPYING.LIB.  If not, write to
+ *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ *  Boston, MA 02110-1301, USA.
+ */
+
+#include <QtTest/QTest>
+
+#include <QSignalSpy>
+#include <QUrl>
+
+#include "browsermanager.h"
+
+using namespace AngelFish;
+
+class UserAgentTest : public QObject
+{
+    Q_OBJECT
+
+private Q_SLOTS:
+
+    void initTestCase()
+    {
+        m_browserManager = new BrowserManager();
+    }
+
+    void cleanupTestCase()
+    {
+        delete m_browserManager;
+    }
+
+    void homepage()
+    {
+        const QString newHomepage = QStringLiteral("https://kde.org");
+
+        m_browserManager->setHomepage(newHomepage);
+        QCOMPARE(m_browserManager->homepage(), newHomepage);
+    }
+
+    void searchEngine()
+    {
+        const QString newSearchEngineUrl = QStringLiteral("https://search.angelfish.kde?q=");
+
+        m_browserManager->setSearchBaseUrl(newSearchEngineUrl);
+        QCOMPARE(m_browserManager->searchBaseUrl(), newSearchEngineUrl);
+    }
+
+    void urlFromUserInput()
+    {
+        const QString incompleteUrl = QStringLiteral("kde.org");
+        const QString completeUrl = QStringLiteral("http://kde.org");
+
+        QCOMPARE(m_browserManager->urlFromUserInput(incompleteUrl), completeUrl);
+    }
+
+private:
+    BrowserManager *m_browserManager;
+};
+
+QTEST_MAIN(UserAgentTest);
+
+#include "browsermanagertest.moc"

autotests/urlmodeltest.cpp

@@ -232,7 +232,7 @@ private Q_SLOTS:
         QVERIFY(model->rowCount(QModelIndex()));
 
         compare(readFile(file1), model);
-    };
+    }
 
     void testAdd()
     {

autotests/useragenttest.cpp

+/*
+ *  Copyright 2019 Jonah Brüchert <jbb@kaidan.im>
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Library General Public
+ *  License version 2 as published by the Free Software Foundation;
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Library General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Library General Public License
+ *  along with this library; see the file COPYING.LIB.  If not, write to
+ *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ *  Boston, MA 02110-1301, USA.
+ */
+
+#include <QtTest/QTest>
+
+#include <QSignalSpy>
+#include <QtWebEngine/QtWebEngineVersion>
+
+#include "useragent.h"
+
+
+class UserAgentTest : public QObject
+{
+    Q_OBJECT
+
+private Q_SLOTS:
+
+    void initTestCase()
+    {
+        m_userAgent = new UserAgent();
+    }
+
+    void cleanupTestCase()
+    {
+        delete m_userAgent;
+    }
+
+    void desktopUserAgent()
+    {
+        m_userAgent->setIsMobile(false);
+        const QString expectedString = QString("Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) QtWebEngine/%1 Chrome/75.0.3770.116 Desktop Safari/537.36")
+                .arg(QTWEBENGINE_VERSION_STR);
+
+        QCOMPARE(m_userAgent->userAgent(), expectedString);
+    }
+
+    void userAgentChanged()
+    {
+        QSignalSpy spy(m_userAgent, &UserAgent::userAgentChanged);
+        m_userAgent->setIsMobile(true);
+        QCOMPARE(spy.count(), 1);
+    }
+
+    void mobileUserAgent()
+    {
+        m_userAgent->setIsMobile(true);
+        const QString expectedString = QString("Mozilla/5.0 (Linux; Plasma Mobile, like Android 9.0) AppleWebKit/537.36 (KHTML, like Gecko) QtWebEngine/%1 Chrome/75.0.3770.116 Mobile Safari/537.36")
+                .arg(QTWEBENGINE_VERSION_STR);
+
+        QCOMPARE(m_userAgent->userAgent(), expectedString);
+    }
+
+    void setIsMobile()
+    {
+        QSignalSpy spy(m_userAgent, &UserAgent::isMobileChanged);
+        m_userAgent->setIsMobile(false);
+        QCOMPARE(spy.count(), 1);
+        m_userAgent->setIsMobile(true);
+        QCOMPARE(spy.count(), 2);
+    }
+
+    void isMobile()
+    {
+        m_userAgent->setIsMobile(false);
+        QCOMPARE(m_userAgent->isMobile(), false);
+        m_userAgent->setIsMobile(true);
+        QCOMPARE(m_userAgent->isMobile(), true);
+    }
+
+private:
+    UserAgent *m_userAgent;
+};
+
+QTEST_MAIN(UserAgentTest);
+
+#include "useragenttest.moc"

src/useragent.cpp

 #include "useragent.h"
 
-#include <QtWebEngine/qtwebengineversion.h>
+#include <QtWebEngine/QtWebEngineVersion>
 #include <QtWebEngine/QQuickWebEngineProfile>
 
 UserAgent::UserAgent(QObject *parent) : QObject(parent)