Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Angelfish
Angelfish
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma Mobile
  • AngelfishAngelfish
  • Merge Requests
  • !97

Merged
Opened Nov 18, 2020 by Jonah Brüchert@jbbgameich🌳Developer5 of 5 tasks completed5/5 tasks

Implement ad blocker

  • Overview 18
  • Commits 2
  • Changes 30

Closes #1 (closed)

How to test:

flatpak-builder tmp --force-clean --ccache org.kde.mobile.angelfish.json --install-deps-from=flathub
flatpak-builder --run tmp org.kde.mobile.angelfish.json angelfish

or

  • Install rust stable (distro packages, rustup)
  • Compile https://github.com/AndrewGaspar/corrosion
  • Compile angelfish as usual.

To do:

  • Remove some debug output
  • decide which lists should be default
  • Allow to disable the ad blocking at runtime
  • Consider making use of https://github.com/brave/adblock-rust/pull/127 later
  • Update flatpak recipe
Edited Nov 27, 2020 by Jonah Brüchert
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: plasma-mobile/angelfish!97
Source branch: work/adblock