Commit 3a81753d authored by Nicolas Fella's avatar Nicolas Fella
Browse files

[kstyle] Use application attribute instead of reading config file to check...

[kstyle] Use application attribute instead of reading config file to check whether to draw menu icons

The current code creates a KSharedConfig for every invokation, which is wasteful

There is an application attribute that we can use to check what we want

plasma-integration sets that attribute based on the same setting we are reading here

This way the config is only read when needed

There is one behavior change: plasma-integration only checks kdeglobals, not the app's config file, so overriding the behavior for one app only is no longer possible. However that's not something we expose in any UI anyway
parent 7077fdf1
Pipeline #124275 passed with stage
in 1 minute and 22 seconds
......@@ -7482,8 +7482,7 @@ namespace Breeze
//____________________________________________________________________
bool Style::showIconsInMenuItems() const
{
const KConfigGroup g(KSharedConfig::openConfig(), "KDE");
return g.readEntry("ShowIconsInMenuItems", true);
return !QApplication::testAttribute(Qt::AA_DontShowIconsInMenus);
}
//____________________________________________________________________
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment