1. 02 Jan, 2021 1 commit
  2. 29 Dec, 2020 1 commit
  3. 20 Dec, 2020 1 commit
  4. 17 Dec, 2020 1 commit
  5. 09 Dec, 2020 2 commits
    • Noah Davis's avatar
      Make Breeze Dark's Complementary color set not complementary · 3a058239
      Noah Davis authored
      Despite the name, Complementary colors are used more like an always available set of dark color scheme colors. This means that in situations where you'd expect colors to always be dark, they become bright white with Breeze Dark because they were given Complementary colors rather than hardcoded dark colors. I don't think all these instances where the complementary color group is used like that will be fixed before Plasma 5.21 is released, so I'm making the Breeze Dark Complementary color set use normal Breeze Dark colors.
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · b5883f2c
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  6. 07 Dec, 2020 1 commit
  7. 03 Dec, 2020 4 commits
  8. 27 Nov, 2020 1 commit
    • Fabian Vogt's avatar
      Fix drawing of styled frames for QQuickItems · 42a885a9
      Fabian Vogt authored
      There is a special case for comboboxes when drawing a styled frame, but for
      some reason it didn't actually check whether the QQuickItem is a combobox,
      there was only a comment...
      This adds the check, which means that QQuickItems get a proper frame now
      instead of a combobox popup.
  9. 23 Nov, 2020 2 commits
    • Fabian Vogt's avatar
      Work around 1px empty header area in a horizonal header RTL · ac671256
      Fabian Vogt authored
      The 1px offset qtbase uses there results in a 1px empty header area at the end,
      even if it fits perfectly. Don't draw a separator there.
    • Fabian Vogt's avatar
      Draw the last header separator in the empty header area instead · a480bd38
      Fabian Vogt authored
      Currently the separators in headers are drawn at the right edge for each
      section. That makes it visible on the rightmost edge of a header, directly
      adjacent to the surrounding frame, surrounding in a 2px wide line.
      (For RTL it's the reverse)
      Avoid the double line by moving the separator to the adjacent "HeaderEmptyArea"
      instead, which is only visible when necessary.
      As a side effect, this commit fixes the check for whether a section is "last"
      for invisible headers and RTL layouts.
  10. 19 Nov, 2020 2 commits
  11. 18 Nov, 2020 1 commit
    • Fabian Vogt's avatar
      Revert "Draw frame outline at the outer edge, not a pixel further inside" · ae65ce30
      Fabian Vogt authored
      This reverts commit 7e678c34 and the followup.
         A       B
      +-----+ +-----+   C
      |     | |XXXXX| +---+
      | XXX | |X   X| |XXX|
      | XCX | |X C X| |XCX|
      | XXX | |X   X| |XXX|
      |     | |XXXXX| +---+
      +-----+ +-----+
      Initially it was A, the referenced commit changed it to be B instead, which
      created a 1px gap between frame and content, and the followup avoids that gap
      by adjusting the frame width, resulting in C.
      Although it's consistent, it leads to a worse apperance in places where the 1px
      margin between frame and rect was expected.
  12. 16 Nov, 2020 1 commit
    • Fabian Vogt's avatar
      Fix gap between control and frame · 7f18a88c
      Fabian Vogt authored
      7e678c34 removed the offsets from all sides, but that created a gap at the
      right and bottom edges. This is because the frame is actually just 1px on
      each side, but Frame_FrameWidth didn't match that.
  13. 13 Nov, 2020 1 commit
  14. 12 Nov, 2020 1 commit
    • Fabian Vogt's avatar
      Notify on color scheme changes · 8d491add
      Fabian Vogt authored
      kde4breeze changes the color scheme when it runs as part of kconf_update,
      but at that time some applications (including kwin) might already be running.
      Those need to be notified of the change.
      BUG: 428771
  15. 11 Nov, 2020 1 commit
    • Michael Weghorn's avatar
      Draw frame outline at the outer edge, not a pixel further inside · 7e678c34
      Michael Weghorn authored
      The documentation for 'QPainter::drawRoundedRect' [1]
      "A filled rectangle has a size of rect.size(). A stroked
      rectangle has a size of rect.size() plus the pen width."
      Therefore, the frame rect passed to that method needs to
      be adjusted according to the pen width for the case where
      the rect is stroked (i.e. an outline exists), and no
      adjustement is needed when the rect is not stroked so
          [size of rect] + [outline width] = [wanted total size]
      The default pen size is 1 (which is also the value
      of 'PenWidth::Frame' used to calculate the radius for the
      outline a few lines further down).
      For the case that an outline exists, the adjustment of
      the rect already happens in the call to 'Helper::strokedRect',
      so there is no need for reducing the rect by one additional
      pixel on each side, which resulted in the frame border
      unnecessarily not being right at the inner edge of the
      rect, but one additional pixel "further inside".
      It looks like the additional adjustment was originally added
      by commit 3dbcea7e
      ("Changed frame width to 2, to cope with focus rect.",
      2014-07-30), later adapted by  commit
      ("Render 2px focused outline *inside* frames rather than outside",
      2014-08-11) and commit 2985b4cb
      ("use one pixel for focus frame instead of 2", 2014-09-22).
      While 'Metrics::Frame_FrameWidth' still has the value 2,
      it is not used here at all, so the default pen width of 1
      Therefore, drop the extra adjustment in order for the
      stroke to be drawn right at the edge of the rect.
      [1] https://doc.qt.io/qt-5/qpainter.html#drawRoundedRect
      BUG: 428973
  16. 07 Nov, 2020 1 commit
  17. 05 Nov, 2020 1 commit
  18. 03 Nov, 2020 1 commit
  19. 01 Nov, 2020 1 commit
  20. 30 Oct, 2020 1 commit
  21. 28 Oct, 2020 1 commit
  22. 27 Oct, 2020 1 commit
  23. 26 Oct, 2020 1 commit
  24. 24 Oct, 2020 3 commits
    • Neal Gompa's avatar
      BreezeLight: Darken the active window header border for legibility · 94ec8340
      Neal Gompa authored
      THe previous color was too difficult for me to distinguish between
      active and inactive windows. This slight darkening of the active
      state improves the legibility while still preserving the "light"
      quality of the style.
    • Dominic Hayes's avatar
      Add 'Breeze Twilight' Global Theme · cea3cf68
      Dominic Hayes authored and Nate Graham's avatar Nate Graham committed
      Breeze Twilight is a variant of Breeze Default that opts for the dark
      variant of the Plasma Style instead.
      With Kubuntu having taken this approach, and with Fedora now considering
      this approach as well, it's time we consider doing it upstream, because
      honestly Breeze Light for Applications + Breeze Dark for Desktop is a
      really nice looking combination.
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 8f21d072
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  25. 23 Oct, 2020 1 commit
  26. 22 Oct, 2020 2 commits
  27. 20 Oct, 2020 2 commits
  28. 19 Oct, 2020 1 commit
  29. 18 Oct, 2020 1 commit
  30. 14 Oct, 2020 1 commit