1. 18 May, 2021 1 commit
    • Fabian Vogt's avatar
      Fix informing the underlying widget when leaving SplitterProxy · ae9639f7
      Fabian Vogt authored
      While the SplitterProxy is active, it intercepts all relevant events, so that
      the underlying widget still thinks it's in the same "on splitter" state. When
      the SplitterProxy is left, the underlying widget is sent a HoverLeave/HoverMove
      event to make it aware of the new current cursor position. Without this, it
      doesn't know that it's not supposed to be in the "on splitter" state, and when
      it regains focus it just re-activates the SplitterProxy at the current cursor
      position.
      
      This was broken by accident in d201a1f1 ("Fix SplitterProxy not clearing
      when above another QSplitterHandle"), which moved the hide() call past the
      call to QCoreApplication::sendEvent. Previously that made isVisible() false,
      which also prevented the interception of the HoverLeave/HoverMove events.
      
      BUG: 436473
      
      
      (cherry picked from commit f99b7ef6)
      ae9639f7
  2. 09 Apr, 2021 2 commits
    • Fabian Vogt's avatar
      Fix SplitterProxy not clearing when above another QSplitterHandle · cc613558
      Fabian Vogt authored
      When two SplitterHandles are next to each other, like at the intersection of a
      horizontal and vertical splitter (|-), then it's possible that hiding the proxy
      of one of those handles causes the other handle to gain focus immediately,
      which activates the SplitterProxy again. Before this patch, it would then
      continue clearing after reenabling itself, leading to an inconsistent state.
      
      BUG: 431921
      (cherry picked from commit d201a1f1)
      cc613558
    • Fabian Vogt's avatar
      Fix logic error in SplitterProxy::setEnabled · 10fbc0ea
      Fabian Vogt authored
      It clears the splitter when enabling it, that seems wrong.
      Despite this bug, it still mostly worked before because the eventFilter checked
      for _enabled anyway.
      
      (cherry picked from commit 4b10546c)
      10fbc0ea
  3. 06 Aug, 2019 1 commit
  4. 28 Jun, 2019 1 commit
    • Hugo Pereira Da Costa's avatar
      - fixed "missing override" warnings · 62ac0c18
      Hugo Pereira Da Costa authored
      - removed useless "virtual" specifications
      - removed useless destructors
      - cleanup variable initializations
      - moved protected methods as private when possible for better encapsulation
      62ac0c18
  5. 17 Apr, 2018 1 commit
    • Fabian Vogt's avatar
      Fix build with Qt 4 · f4f7b599
      Fabian Vogt authored
      Summary:
      In Qt 4, the compiler detection macros have no value, so they can't be compared
      against. So just use the compiler-specific ones.
      It also makes use of the fact that undefined tokens evaluate to 0 in
      comparisons.
      
      Test Plan: jriddell built it with GCC 5 and 7 against Qt 4 and 5.
      
      Reviewers: #breeze, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12277
      f4f7b599
  6. 03 Apr, 2018 1 commit
  7. 03 Feb, 2018 1 commit
  8. 20 Aug, 2017 1 commit
  9. 19 Jan, 2015 1 commit
  10. 12 Sep, 2014 1 commit
  11. 09 Sep, 2014 1 commit
  12. 26 Aug, 2014 2 commits
  13. 20 Aug, 2014 3 commits