plasma-workspace#9

Jan Blackquill authored Apr 14, 2022 and Jan Blackquill committed Apr 14, 2022

- buttons now flatten
- default buttons don't show their blue colour, because, they aren't the
  button that'll get triggered on enter if their window isn't active

GIT_SILENT

This fixes the contrast of tabs on dark themes by using
a darkening factor on the Window colour, adjusted for
whether it's light or dark, instead of using the Shadow
colour for both light and dark themes.

BUG: 438627
FIXED-IN: 5.25

No CI setup yet as we need Plasma seed jobs for KF6 first.

Tatsuyuki Ishi authored Oct 01, 2021 and Noah Davis committed Oct 11, 2021

QPainter's auto-scaling is prone to off-by-one rounding errors and draws on
fractional coordinates. With this change, we paint on a 1x DPR QPainter and
scale the shadow offset and strength manually based on DPR.

This resolves an issue with resulting in seams on the right and bottom
edges of a menu due to shadow boundaries being off-by-one.

BUG: 418166

v2: remove unrelated formatting changes
v3:
- move the DPR helper to ShadowHelper
- retrieve the DPR from the widget instead of the global QGuiApplication
- added BUG reference

The previous way it was painted was kind of messy in the sense that
other parts overlapped with the active tab when they shouldn't have or
didn't overlap enough like with the highlight. There were also some
painting artifacts that were just weird and are now gone.

This will prevent them from drifting out of sync over time.

- Use a very slight gradient
- Use blue for pressed state
- Make shadow vertical, not diagonal

- Use gray for checked buttons

Some people thought blue checked buttons were pretty, but some people
thought they demanded too much attention. In order to merge the changes
faster, I switched to using gray for checked buttons.

We've gotten some feedback that radio buttons look like big creepy eyes
that are staring at you. To reduce that effect, this commit makes the
center dots a bit smaller.

Jan Blackquill authored May 27, 2021 and Nate Graham committed Jun 08, 2021

This fixes the application of _kde_highlight_neutral to radiobuttons
and checkbuttons.

Jan Blackquill authored May 10, 2021 and Nate Graham committed Jun 08, 2021

BUG: 420498

Jan Blackquill authored May 06, 2021 and Nate Graham committed Jun 08, 2021

BUG: 414990

This property, when set, will cause menus to drop their top border + their top corner rounding.

Jan Blackquill authored Feb 02, 2021 and Nate Graham committed Mar 20, 2021

BUG: 356037

Jan Blackquill authored Feb 25, 2021 and Nate Graham committed Feb 26, 2021

This reverts commit 2f351fe1.

We hve not yet figured out how to apply this style consistently
and were unable to implement it for controls other than text fields
in Plasma 5.21, so it is better to remove it for now than to have an
inconsistent UI. We will re-evaluate this for Plasma 5.22.

BUG: 430944
BUG: 430943
BUG: 433421
FIXED-IN: 5.21.2

This reverts commit 7e678c34 and the followup.

   A       B
+-----+ +-----+   C
|     | |XXXXX| +---+
| XXX | |X   X| |XXX|
| XCX | |X C X| |XCX|
| XXX | |X   X| |XXX|
|     | |XXXXX| +---+
+-----+ +-----+

Initially it was A, the referenced commit changed it to be B instead, which
created a 1px gap between frame and content, and the followup avoids that gap
by adjusting the frame width, resulting in C.

Although it's consistent, it leads to a worse apperance in places where the 1px
margin between frame and rect was expected.

The documentation for 'QPainter::drawRoundedRect' [1]
says:

"A filled rectangle has a size of rect.size(). A stroked
rectangle has a size of rect.size() plus the pen width."

Therefore, the frame rect passed to that method needs to
be adjusted according to the pen width for the case where
the rect is stroked (i.e. an outline exists), and no
adjustement is needed when the rect is not stroked so
that

    [size of rect] + [outline width] = [wanted total size]

The default pen size is 1 (which is also the value
of 'PenWidth::Frame' used to calculate the radius for the
outline a few lines further down).

For the case that an outline exists, the adjustment of
the rect already happens in the call to 'Helper::strokedRect',
so there is no need for reducing the rect by one additional
pixel on each side, which resulted in the frame border
unnecessarily not being right at the inner edge of the
rect, but one additional pixel "further inside".

It looks like the additional adjustment was originally added
by commit 3dbcea7e
("Changed frame width to 2, to cope with focus rect.",
2014-07-30), later adapted by  commit
f288c34c
("Render 2px focused outline *inside* frames rather than outside",
2014-08-11) and commit 2985b4cb
("use one pixel for focus frame instead of 2", 2014-09-22).

While 'Metrics::Frame_FrameWidth' still has the value 2,
it is not used here at all, so the default pen width of 1
applies.

Therefore, drop the extra adjustment in order for the
stroke to be drawn right at the edge of the rect.

[1] https://doc.qt.io/qt-5/qpainter.html#drawRoundedRect

BUG: 428973

Currently the condition in the #if directive evaluates to false (sorry
for breaking it!).

In order to prevent breaking Helper::isX11() in the future, this change
removes the #if directive. It's okay to do so because KWindowSystem
provides a platform-independent API.

Summary: There is now a tools area.

Test Plan:
{F8132249}

{F8132260} (no border drawn when titlebar and content colours are the same)

{F8132252}

{F8132253}

Reviewers: #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham

Reviewed By: #breeze, #vdg, hpereiradacosta, ngraham

Subscribers: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel

Tags: #plasma

Maniphest Tasks: T10201, T11661

Differential Revision: https://phabricator.kde.org/D27669

BUG: 426651

QWindow::startSystemMove() is a new feature in Qt 5.15 that provides a
platform-independent way to start an interactive move operation.

I was in a video call with Volker and asked him under which license the GtkUpdateIconCache
is licensed.

Task related : Figure out a good UI for the "show which settings have been changed" feature https://phabricator.kde.org/T13008

This patch introduces a new property to allow to highlight some widgets when we want to draw user's attention on specific widgets.

Also remove some unecessary inclusions of breeze.h

Summary:
Caused icons to be not longer recolored when changing the color scheme until an
application is started again

Test Plan: Change color scheme while having an application open, icons should change color correctly

Reviewers: #breeze, #plasma, ndavis

Reviewed By: #breeze, ndavis

Subscribers: ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29012