1. 15 Jan, 2020 4 commits
    • Noah Davis's avatar
      Use Text instead of WindowText for scrollbar border · d336cca2
      Noah Davis authored
      Hugo Pereira Da Costa said Text is better because scrollbar are usually
      rendered over item views.
      d336cca2
    • Noah Davis's avatar
      Fix hardcoded scrollbar separator width · e606b264
      Noah Davis authored
      e606b264
    • Marco Martin's avatar
      show a thin separator between view and scrollbar · df134061
      Marco Martin authored
      Summary:
      This look makes listviews look way better, not having the selected
      items look truncated into nothingness.
      Always display "big" handles, due to the numerous complaints of the slim handles not being obvious
      
      Test Plan:
      Before:
      {F7882628}
      After:
      {F7882624}
      
      Reviewers: #plasma, #breeze, #vdg, ngraham, hpereiradacosta
      
      Reviewed By: #vdg, ngraham, hpereiradacosta
      
      Subscribers: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9126
      
      Differential Revision: https://phabricator.kde.org/D26655
      df134061
    • Marco Martin's avatar
      Make the scrollbar always thick · 6694eb7a
      Marco Martin authored
      Summary:
      Second part of D26655, removes the thin scrollbar and makes it always thick
      to implement the desired design
      
      BUG: 396747
      FIXED-IN: 5.18.0
      
      Test Plan: {F7884060}
      
      Reviewers: #plasma, #vdg, #breeze, ngraham, ndavis
      
      Reviewed By: #vdg, #breeze, ngraham, ndavis
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9126
      
      Differential Revision: https://phabricator.kde.org/D26685
      6694eb7a
  2. 13 Jan, 2020 3 commits
    • Noah Davis's avatar
      Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists · 3e9cd8d1
      Noah Davis authored
      Summary: If the widget has an item view parent, use the View Background color. Otherwise, use Window Background.
      
      Test Plan: {F7881597, size=full}
      
      Reviewers: #vdg, #breeze, hpereiradacosta, ngraham
      
      Reviewed By: #vdg, hpereiradacosta
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26639
      3e9cd8d1
    • Noah Davis's avatar
      3577d15f
    • Noah Davis's avatar
      Always render checkbox/radiobutton background · 98781f18
      Noah Davis authored
      Summary:
      QQC2/Kirigami checkboxes and radio buttons can turn invisible when rendered over a selected item because their background isn't rendered and they don't have any hacks to detect when they're being rendered over a selected list item.
      
      While the problem isn't technically a Breeze QStyle problem and a hack could be made for QQC2/Kirigami, I don't think there's any great style benefit to not rendering a background for the checkbox. I suppose there is a performance benefit to not rendering a checkbox background except for when the background is different from normal. In my testing with GammaRay's paint analyzer, the checkbox background has a cost less than 5%. The radiobutton background has a cost of 15-20% (maybe it can be improved?).
      
      Reviewers: #vdg, #breeze, #plasma, hpereiradacosta, ngraham
      
      Reviewed By: #vdg, hpereiradacosta, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26572
      98781f18
  3. 04 Jan, 2020 1 commit
  4. 29 Dec, 2019 1 commit
  5. 21 Dec, 2019 1 commit
    • Noah Davis's avatar
      Revert "Revert "Reduce the indicator arrow size for press-and-hold menus in QToolButtons"" · 288c3b85
      Noah Davis authored
      Summary:
      This reverts commit c9aa5358.
      
      Also makes the small down arrow pixel perfect. I will make the other arrows pixel perfect in a separate patch.
      
      After D19890 (27bcd1be) was reopened, there was some discussion about the reason it was reverted and the problems it introduced. It is possible that an icon could partially cover this arrow, but it seemed uncommon enough that ignoring the problem was deemed acceptable. The type of control that this arrow is used for is also pretty uncommon because it does not feel very good to use with a mouse or touchpad.
      
      Reviewers: #vdg, #breeze, #plasma, hpereiradacosta, ngraham
      
      Reviewed By: #vdg, #breeze, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26139
      288c3b85
  6. 14 Dec, 2019 2 commits
    • Noah Davis's avatar
    • Noah Davis's avatar
      Fix rubberband selection outline position · 80650e0e
      Noah Davis authored
      Summary:
      Before this patch, the outline of the rubberband selection control was down and to the right half a pixel too far.
      This wasn't visible at 1x scaling because of the lack of antialiasing, but resulted in the top/left being too thin and bottom/right being too thick on high DPI displays.
      To fix the issue, I enabled antialiasing and moved all sides inwards by half a pixel so that the outline would be pixel perfect.
      I also added a function to get a QRectF with the correct size and position for rectangles with pen strokes.
      
      Test Plan:
      - Open dolphin and make a selection with the mouse
      - Go to a Folder View Plasma widget and make a selection with the mouse
      
      2x scaling
      before: {F7818498, size=full}
      after: {F7818500, size=full}
      
      3x scaling
      before: {F7818484}
      after: {F7818483}
      
      Reviewers: #vdg, #breeze, #plasma, hpereiradacosta, broulik
      
      Reviewed By: hpereiradacosta
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma, #breeze, #vdg
      
      Differential Revision: https://phabricator.kde.org/D26001
      80650e0e
  7. 10 Dec, 2019 1 commit
  8. 19 Oct, 2019 1 commit
  9. 14 Oct, 2019 1 commit
    • Albert Astals Cid's avatar
      Micro optimizations · 993c96a0
      Albert Astals Cid authored
      Summary:
      Add some const & for things that return const & so there's no need to make a copy
      Add a std::move for a thing that we pass by copy and it's just saved in another variable
      
      Reviewers: zzag
      
      Reviewed By: zzag
      
      Subscribers: zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24614
      993c96a0
  10. 07 Oct, 2019 1 commit
  11. 17 Sep, 2019 1 commit
  12. 17 Aug, 2019 1 commit
  13. 16 Aug, 2019 3 commits
  14. 15 Aug, 2019 1 commit
    • Noah Davis's avatar
      Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu · b43e19e3
      Noah Davis authored
      Summary: Apparently, the code to adjust the rectangle when a menu is present is what was causing the problem. Also added an if statement to move the separator with the button when sunken.
      
      Test Plan:
      Old:
      {F7248297, size=full}
      {F7248298, size=full}
      
      New:
      {F7248300, size=full}
      {F7248301, size=full}
      
      Reviewers: #vdg, #breeze, ngraham
      
      Reviewed By: #vdg, #breeze, ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23169
      b43e19e3
  15. 06 Aug, 2019 1 commit
  16. 05 Jul, 2019 1 commit
    • Hugo Pereira Da Costa's avatar
      Remove unneeded 1 pixel margin around side panels · d6b2a3a3
      Hugo Pereira Da Costa authored
      Summary:
      Remove unneeded 1 pixel margin around side panels, namely QAbstractScrollArea with property _kde_side_panel_view set to true.
      In order to be able to still draw a vertical line on the side of the list, a one pixel margin is kept, on this side only, using SE_FrameContent subelementRect
      The viewport background is kept to QPalette::Base, as for regular lists.
      The logic in polishScrollArea has been adjusted accordingly
      
      Differential Revision: https://phabricator.kde.org/D22138
      d6b2a3a3
  17. 28 Jun, 2019 1 commit
    • Hugo Pereira Da Costa's avatar
      - fixed "missing override" warnings · 62ac0c18
      Hugo Pereira Da Costa authored
      - removed useless "virtual" specifications
      - removed useless destructors
      - cleanup variable initializations
      - moved protected methods as private when possible for better encapsulation
      62ac0c18
  18. 07 Jun, 2019 2 commits
    • Sebastian Kügler's avatar
      re-read color palettes when application color changes · 9d6c7c7f
      Sebastian Kügler authored
      Summary:
      Without this patch, changing the application color scheme from system
      settings only affects some widgets. Notably, checkboxes highlighting
      colors stays the old color, leading to a hodge-podge color scheme and
      bad contrast on some items.
      
      The breeze QStyle caches the colors read via KSharedConfig, so it needs
      to re-read the configuration when the application color changes.
      QApplication emits a signal (originating in KGlobalSettings), which we
      can react to.
      
      This fixes the coloring of various widgets in breeze right after color
      changes.
      
      BUG:408416
      FIXED-IN: 5.16
      
      Those I haven't tested, but look quite suspicious (so please re-test):
      CCBUG:382505
      CCBUG:355295
      
      Test Plan:
      1. open kcmshell5 colors
      2. change to a theme with a different highlight color
      3. apply
      * without patch: checkbox in color KCM (and a whole lot of other
        widgets all over the place) don't change colors
      * with patch: colors change as expected
      
      Reviewers: #plasma, broulik, sitter
      
      Reviewed By: #plasma, broulik, sitter
      
      Subscribers: sitter, cfeck, broulik, zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21646
      9d6c7c7f
    • Sebastian Kügler's avatar
      re-read color palettes when application color changes · 092d4460
      Sebastian Kügler authored
      Summary:
      Without this patch, changing the application color scheme from system
      settings only affects some widgets. Notably, checkboxes highlighting
      colors stays the old color, leading to a hodge-podge color scheme and
      bad contrast on some items.
      
      The breeze QStyle caches the colors read via KSharedConfig, so it needs
      to re-read the configuration when the application color changes.
      QApplication emits a signal (originating in KGlobalSettings), which we
      can react to.
      
      This fixes the coloring of various widgets in breeze right after color
      changes.
      
      BUG:408416
      FIXED-IN: 5.16
      
      Those I haven't tested, but look quite suspicious (so please re-test):
      CCBUG:382505
      CCBUG:355295
      
      Test Plan:
      1. open kcmshell5 colors
      2. change to a theme with a different highlight color
      3. apply
      * without patch: checkbox in color KCM (and a whole lot of other
        widgets all over the place) don't change colors
      * with patch: colors change as expected
      
      Reviewers: #plasma, broulik, sitter
      
      Reviewed By: #plasma, broulik, sitter
      
      Subscribers: sitter, cfeck, broulik, zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21646
      092d4460
  19. 07 Apr, 2019 1 commit
  20. 27 Mar, 2019 1 commit
  21. 04 Feb, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Use correct window for getting ComboBox current icon pixmap · afef901a
      Kai Uwe Broulik authored
      In widgets:
      * windowHandle() only works for top level widgets (windows), so we need to first get the actual window() as windowHandle() is always
        nullptr for controls like ComboBox
      
      In QtQuick Controls:
      * we would just blow up for accessing widget which is null here. Use the QQuickWindow of the QQuickItem, if any. Given how long this
        went unnoticed shows that Qt *never* ever had icons working in ComboBoxes in QtQuick...
      
      Differential Revision: https://phabricator.kde.org/D18655
      afef901a
  22. 05 Sep, 2018 1 commit
  23. 17 Aug, 2018 1 commit
  24. 31 Jul, 2018 1 commit
  25. 17 Jun, 2018 1 commit
  26. 07 Jun, 2018 6 commits