Commit ebae01db authored by Andy Kluger's avatar Andy Kluger Committed by Nate Graham

Invert shade button by same logic as keep-above button

Summary:
What do say we invert the shade button when it's in a "checked" state, as we do the keep-above button?

The window decoration theme already inverts the keep-above button's colors when its state is activated, as a "loud" visual cue. The shade button similarly has an active state to indicate, but lacks such a loud cue to help avoid confusion. Depending on a user's other settings, there may be little or no visual indication (other than the nice but modest flip of the button) that a shaded window decoration doesn't belong to the window seen below it.

I'm attaching two screenshots of this patch applied, with a konsole window in both keep-above and shade states, directly over another window's titlebar.

{F6141905}

{F6141930}

Reviewers: #breeze, ngraham, #vdg

Reviewed By: #breeze, ngraham, #vdg

Subscribers: ngraham, plasma-devel

Tags: #plasma, #breeze

Differential Revision: https://phabricator.kde.org/D14389
parent cc24d25a
......@@ -368,7 +368,7 @@ namespace Breeze
return d->titleBarColor();
} else if( ( type() == DecorationButtonType::KeepBelow || type() == DecorationButtonType::KeepAbove ) && isChecked() ) {
} else if( ( type() == DecorationButtonType::KeepBelow || type() == DecorationButtonType::KeepAbove || type() == DecorationButtonType::Shade ) && isChecked() ) {
return d->titleBarColor();
......@@ -404,7 +404,7 @@ namespace Breeze
if( type() == DecorationButtonType::Close ) return c->color( ColorGroup::Warning, ColorRole::Foreground );
else return KColorUtils::mix( d->titleBarColor(), d->fontColor(), 0.3 );
} else if( ( type() == DecorationButtonType::KeepBelow || type() == DecorationButtonType::KeepAbove ) && isChecked() ) {
} else if( ( type() == DecorationButtonType::KeepBelow || type() == DecorationButtonType::KeepAbove || type() == DecorationButtonType::Shade ) && isChecked() ) {
return d->fontColor();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment