cmake/flatpak: prefer using a target to a bool variable

libdiscover/CMakeLists.txt

@@ -42,7 +42,7 @@ ecm_qt_declare_logging_category(discovercommon_SRCS HEADER libdiscover_debug.h I
 
 
 add_library(DiscoverCommon ${discovercommon_SRCS})
-if(AppStreamQt_FOUND)
+if(TARGET AppStreamQt)
     target_sources(DiscoverCommon PRIVATE
         appstream/OdrsReviewsBackend.cpp
         appstream/AppStreamIntegration.cpp

[Vlad Zahorodnii]

What are the advantages of if (TARGET ...) over if (package_FOUND)?

[Aleix Pol Gonzalez]

Sorry Vlad, missed your question. I prefer targets because it's the only thing we need: it has all the information like includes, compile definitions etc while a variable is something volatile that can even sometimes be cached and unreliable.