Commit 24005fb8 authored by Nate Graham's avatar Nate Graham
Browse files

Show loading placeholder while reviews are loading

Otherwise there's just an empty space on the page that abruptly fills
with content after a few moments. It's nicer to show a loading
placeholder in place of the content while it loads.
parent 4da37b0f
Pipeline #207302 passed with stage
in 1 minute and 36 seconds
......@@ -546,6 +546,15 @@ DiscoverPage {
Kirigami.LoadingPlaceholder {
Layout.alignment: Qt.AlignHCenter
Layout.maximumWidth: Kirigami.Units.gridUnit * 15
Layout.bottomMargin: appInfo.internalSpacings * 2
// FIXME: how do we distinguish between "reviews are empty because they haven't loaded" and "reviews are empty because there are no reviews"?
visible: !rep.count > 0 /*&& reviewsModel.count > 0*/
text: i18n("Loading reviews for %1",
Kirigami.Heading {
Layout.fillWidth: true
visible: rep.count > 0
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment