Commit 27a77073 authored by Nate Graham's avatar Nate Graham
Browse files

Make all OverlaySheets window-modal

Right now half of Discover's OverlaySheets are view-modal and the other
half are window-modal. This feels arbitrary to the user, and view-modal
sheets look weird since the global drawer doesn't darken. This is
because it's still interactive, but there's really no point in being
able to interact with the global drawer while a sheet is open anyway. So
let's just make them all window-modal.

BUG: 426065
FIXED-IN: 5.20
parent 02c1d389
......@@ -8,6 +8,8 @@ import org.kde.kirigami 2.0 as Kirigami
Kirigami.OverlaySheet
{
id: addonsView
parent: applicationWindow().overlay
property alias application: addonsModel.application
property bool isInstalling: false
readonly property bool containsAddons: rep.count>0 || isExtended
......
......@@ -423,6 +423,5 @@ DiscoverPage {
readonly property var addons: AddonsView {
id: addonsView
application: appInfo.application
parent: overlay
}
}
......@@ -8,6 +8,7 @@ import org.kde.kirigami 2.10 as Kirigami
Kirigami.OverlaySheet
{
id: reviewDialog
parent: applicationWindow().overlay
property QtObject application
readonly property alias rating: ratingInput.rating
......
......@@ -27,6 +27,7 @@ import org.kde.kirigami 2.0 as Kirigami
Kirigami.OverlaySheet {
id: page
parent: applicationWindow().overlay
property alias model: reviewsView.model
readonly property QtObject reviewsBackend: resource.backend.reviewsBackend
......@@ -34,8 +35,9 @@ Kirigami.OverlaySheet {
readonly property var rd: ReviewDialog {
id: reviewDialog
parent: applicationWindow().overlay
application: page.resource
parent: overlay
backend: page.reviewsBackend
onAccepted: backend.submitReview(resource, summary, review, rating)
}
......
......@@ -104,6 +104,8 @@ DiscoverPage {
id: sourceProceedDialog
Kirigami.OverlaySheet {
id: sheet
parent: applicationWindow().overlay
showCloseButton: false
property QtObject sourcesBackend
property alias title: heading.text
......
......@@ -36,6 +36,8 @@ DiscoverPage
readonly property var sheet: Kirigami.OverlaySheet {
id: sheet
parent: applicationWindow().overlay
header: Kirigami.Heading { text: i18n("Update Issue") }
ColumnLayout {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment