KNS: Don't add the fallback screenshot if it's already present

2c131e8d · Aleix Pol Gonzalez · bdbe226d · 2c131e8d
Commit 2c131e8d authored Jan 24, 2018 by Aleix Pol Gonzalez 🐧
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

libdiscover/backends/KNSBackend/KNSResource.cpp libdiscover/backends/KNSBackend/KNSResource.cpp +6 -4

No files found.
--- a/libdiscover/backends/KNSBackend/KNSResource.cpp
+++ b/libdiscover/backends/KNSBackend/KNSResource.cpp
@@ -166,10 +166,12 @@ QString KNSResource::section()

 static void appendIfValid(QList<QUrl>& list, const QUrl &value, const QUrl &fallback = {})
 {
-    if (value.isValid() && !value.isEmpty() && !list.contains(value))
-        list << value;
-    else if (!fallback.isEmpty())
-        appendIfValid(list, fallback);
+    if (list.contains(value)) {
+        if (value.isValid() && !value.isEmpty())
+            list << value;
+        else if (!fallback.isEmpty())
+            appendIfValid(list, fallback);
+    }
 }

 void KNSResource::fetchScreenshots()