Commit 47d77057 authored by Nathaniel Graham's avatar Nathaniel Graham
Browse files

Improve "show more reviews" string and logic

Summary:
Use slightly more natural text for the "show more reviews" button.

Also fix the bug where the "show more reviews" text would be absent if `rating` was null, which triggered logic that set the number of reviews to be 0. This didn't seem to be adding anything, so I removed it and everything still seems to work fine.

Test Plan:
Browsed a ton of apps. All appeared as expected, including apps like OpenScad that were previously affected by the above bug.

{F5712478}

Reviewers: #discover_software_store, apol

Reviewed By: #discover_software_store, apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10527
parent 90271ce0
......@@ -206,9 +206,8 @@ DiscoverPage {
}
LinkButton {
id: commentsButton
readonly property QtObject rating: appInfo.application.rating
visible: rating && rating.ratingCount>0 && reviewsModel.count
text: i18n("Show more reviews (%1)...", rating ? reviewsModel.count : 0)
visible: reviewsModel.count > 0
text: i18n("Show all %1 reviews...", reviewsModel.count)
onClicked: {
reviewsSheet.open()
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment