Commit 85f6a6a0 authored by Nate Graham's avatar Nate Graham
Browse files

Use a consistent visual style on the Settings page

Summary: This patch makes the Settings page visually consistent with the Updates page. Now that both have (with the Breeze color scheme) a gray background, with white list items than span the full width. Button placement is also improved, thanks to a recent Kirigami patch that automatically moves it in a bit when a scrollbar is visible.

Test Plan:
Here's what the {nav Updates} page whose style we want to match currently looks like:

Settings page, before:

Settings page, after:

Reviewers: apol, #discover_software_store

Reviewed By: apol, #discover_software_store

Subscribers: plasma-devel

Tags: #plasma

Differential Revision:
parent 0a468792
......@@ -12,13 +12,6 @@ DiscoverPage {
title: i18n("Settings")
property string search: ""
Kirigami.Theme.inherit: false
Kirigami.Theme.colorSet: Kirigami.Theme.View
background: Rectangle {
color: Kirigami.Theme.backgroundColor
contextualActions: [
KirigamiActionBridge { action: app.action("help_about_app") },
KirigamiActionBridge { action: app.action("help_report_bug") }
......@@ -41,25 +34,23 @@ DiscoverPage {
readonly property QtObject backend: SourcesModel.sourcesBackendByName(section)
readonly property QtObject resourcesBackend: backend.resourcesBackend
readonly property bool isDefault: ResourcesModel.currentApplicationBackend == resourcesBackend
RowLayout {
Layout.fillHeight: true
Connections {
target: backendItem.backend
onPassiveMessage: window.showPassiveNotification(message)
anchors {
right: parent.right
left: parent.left
rightMargin: parent.rightPadding
leftMargin: parent.leftPadding
Kirigami.Heading {
Layout.fillWidth: true
Layout.leftMargin: Kirigami.Units.smallSpacing
Layout.alignment: Qt.AlignVCenter
text: backendItem.isDefault ? i18n("%1 (Default)", resourcesBackend.displayName) : resourcesBackend.displayName
level: 3
Button {
Layout.rightMargin: Kirigami.Units.smallSpacing
Layout.alignment: Qt.AlignVCenter "preferences-other"
visible: resourcesBackend && resourcesBackend.hasApplications
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment