Commit 9ce5d98d authored by Nate Graham's avatar Nate Graham Committed by Aleix Pol Gonzalez
Browse files

Remove non-useful tooltip while loading updates

This tooltip was added to help diagnose issues with stuck backends, but
has proven troublesome. This commit removes it for the following
reasons:

1. It did not succeed in fixing the problem in the first place because
   the root cause always seems to be the PackageKit backend being stuck
   for a moment and not issuing updates, so the tooltip doesn't change at
   all or even tell us which backend is stuck.
2. Due to a bug, the tooltip was always shown when the cursor was
   hovered anywhere over the main panel, so users saw it much more than
   we wanted and filed many bug reports.

This commit partially reverts 2196ed49.

BUG: 432044
FIXED-IN: 5.21.5
parent b3399118
......@@ -12,7 +12,6 @@ DiscoverPage
title: i18n("Updates")
property string footerLabel: ""
property string footerToolTip: ""
property int footerProgress: 0
property bool isBusy: false
......@@ -184,9 +183,6 @@ DiscoverPage
horizontalAlignment: Text.AlignHCenter
text: page.footerLabel
wrapMode: Text.WordWrap
ToolTip.text: page.footerToolTip
ToolTip.visible: hovered && page.footerToolTip.length > 0
ToolTip.delay: Kirigami.Units.toolTipDelay
level: 2
}
Button {
......@@ -350,17 +346,6 @@ DiscoverPage
PropertyChanges { target: page; footerLabel: i18nc("@info", "Fetching updates...") }
PropertyChanges { target: statusLabel; opacity: 1 }
PropertyChanges { target: page; footerProgress: ResourcesModel.fetchingUpdatesProgress }
PropertyChanges { target: page; footerToolTip: {
var ret = "";
for (var i in ResourcesModel.backends) {
var backend = ResourcesModel.backends[i]
if (!backend.isFetching)
continue
ret += i18n("%1 (%2%)\n", backend.name, backend.fetchingUpdatesProgress)
}
return ret
}
}
PropertyChanges { target: page; isBusy: true }
PropertyChanges { target: updatesView; opacity: 0 }
},
......
......@@ -374,13 +374,6 @@ void ResourcesModel::checkForUpdates()
backend->checkForUpdates();
}
QVariantList ResourcesModel::backendsVariant() const
{
return kTransform<QVariantList>(m_backends, [](AbstractResourcesBackend *b) {
return QVariant::fromValue<QObject *>(b);
});
}
AbstractResourcesBackend *ResourcesModel::currentApplicationBackend() const
{
return m_currentApplicationBackend;
......
......@@ -74,7 +74,6 @@ class DISCOVERCOMMON_EXPORT ResourcesModel : public QObject
Q_PROPERTY(int updatesCount READ updatesCount NOTIFY updatesCountChanged)
Q_PROPERTY(bool hasSecurityUpdates READ hasSecurityUpdates NOTIFY updatesCountChanged)
Q_PROPERTY(bool isFetching READ isFetching NOTIFY fetchingChanged)
Q_PROPERTY(QVariantList backends READ backendsVariant NOTIFY backendsChanged)
Q_PROPERTY(AbstractResourcesBackend *currentApplicationBackend READ currentApplicationBackend WRITE setCurrentApplicationBackend NOTIFY
currentApplicationBackendChanged)
Q_PROPERTY(DiscoverAction *updateAction READ updateAction CONSTANT)
......@@ -105,7 +104,6 @@ public:
QString applicationSourceName() const;
QVariantList backendsVariant() const;
void setCurrentApplicationBackend(AbstractResourcesBackend *backend, bool writeConfig = true);
AbstractResourcesBackend *currentApplicationBackend() const;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment