Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
Discover
Commits
b26e095e
Commit
b26e095e
authored
Nov 19, 2020
by
Aleix Pol Gonzalez
🐧
Browse files
Fix tests
parent
9b59d777
Changes
5
Hide whitespace changes
Inline
Side-by-side
discover/autotests/DiscoverTest.qml
View file @
b26e095e
...
...
@@ -37,6 +37,15 @@ Item
return
obj
&&
obj
.
toString
().
indexOf
(
typename
+
"
_QMLTYPE_
"
)
===
0
}
function
chooseChildren
(
objects
,
validator
)
{
for
(
var
v
in
objects
)
{
var
obj
=
objects
[
v
];
if
(
validator
(
obj
))
return
true
;
}
return
false
;
}
function
chooseChild
(
obj
,
validator
)
{
verify
(
obj
,
"
can't find a null's child
"
)
if
(
validator
(
obj
))
...
...
@@ -103,6 +112,7 @@ Item
done
=
true
;
for
(
var
v
in
testRoot
)
{
if
(
v
.
indexOf
(
"
test_
"
)
===
0
)
{
console
.
log
(
"
doing
"
,
v
)
testRoot
.
currentTest
=
v
;
testRoot
.
reset
();
testRoot
[
v
]();
...
...
discover/autotests/appstreamUrl.qml
View file @
b26e095e
...
...
@@ -5,7 +5,7 @@ DiscoverTest
{
function
test_open
()
{
verify
(
appRoot
.
stack
.
currentItem
,
"
has a loading page
"
);
compare
(
appRoot
.
stack
.
currentItem
.
title
,
""
,
"
same title
"
);
compare
(
appRoot
.
stack
.
currentItem
.
title
,
"
techie1
"
,
"
same title
"
);
compare
(
appRoot
.
stack
.
currentItem
.
application
.
packageName
,
"
techie1
"
,
"
pkgname
"
);
}
}
discover/autotests/packageArgument.qml
View file @
b26e095e
...
...
@@ -7,7 +7,6 @@ DiscoverTest
verify
(
appRoot
.
stack
.
currentItem
,
"
has a page
"
);
while
(
appRoot
.
stack
.
currentItem
.
title
===
"
Loading...
"
)
waitForRendering
();
compare
(
appRoot
.
stack
.
currentItem
.
title
,
""
,
"
same title
"
);
compare
(
appRoot
.
stack
.
currentItem
.
application
.
packageName
,
"
CMakeLists.txt
"
,
"
pkgname
"
);
}
}
discover/autotests/toplevels.qml
View file @
b26e095e
...
...
@@ -24,16 +24,10 @@ DiscoverTest
function
test_openHome
()
{
var
drawer
=
appRoot
.
globalDrawer
;
var
firstitem
;
chooseChild
(
drawer
,
function
(
object
)
{
if
(
object
.
hasOwnProperty
(
"
label
"
)
&&
object
.
label
.
indexOf
(
"
ummy
"
)
>
0
)
{
firstitem
=
object
;
return
true
}
return
false
;
});
var
categoryName
=
"
dummy 3
"
;
firstitem
.
clicked
()
drawer
.
actions
[
0
].
children
[
2
].
trigger
()
compare
(
appRoot
.
stack
.
currentItem
.
title
,
"
dummy 3
"
,
"
same title
"
);
app
.
openMode
(
"
Browsing
"
);
compare
(
appRoot
.
stack
.
currentItem
.
title
,
"
Featured
"
,
"
same title
"
);
compare
(
drawer
.
currentSubMenu
,
null
)
...
...
@@ -41,14 +35,7 @@ DiscoverTest
function
test_navigateThenUpdate
()
{
var
drawer
=
appRoot
.
globalDrawer
;
var
firstitem
;
chooseChild
(
drawer
,
function
(
object
)
{
if
(
object
.
hasOwnProperty
(
"
label
"
)
&&
object
.
label
.
indexOf
(
"
ummy
"
)
>
0
)
{
firstitem
=
object
;
return
true
}
return
false
;
});
var
firstitem
=
drawer
.
actions
[
0
].
children
[
2
]
var
updateButton
;
chooseChild
(
drawer
,
function
(
object
)
{
if
(
object
.
objectName
===
"
updateButton
"
)
{
...
...
@@ -58,7 +45,7 @@ DiscoverTest
return
false
;
});
firstitem
.
clicked
()
firstitem
.
trigger
()
verify
(
updateButton
.
enabled
)
updateButton
.
clicked
()
...
...
libdiscover/backends/FwupdBackend/FwupdResource.cpp
View file @
b26e095e
...
...
@@ -127,12 +127,10 @@ void FwupdResource::fetchChangelog()
void
FwupdResource
::
setState
(
AbstractResource
::
State
state
)
{
if
(
m_state
!=
state
)
{
if
(
m_state
!=
state
)
{
m_state
=
state
;
emit
stateChanged
();
}
}
void
FwupdResource
::
invokeApplication
()
const
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment