Commit c46e703e authored by Aleix Pol Gonzalez's avatar Aleix Pol Gonzalez 🐧
Browse files

flatpak: Don't treat the lack of metadata as fatal

We need remotes for listing as well as for searching.
Also don't mention it to the user, they probably don't have much they
can do besides knowing it's a problem or reporting to the remote's
maintainer.

BUG: 443745
parent eda7dfca
Pipeline #126087 passed with stage
in 1 minute and 5 seconds
......@@ -1588,8 +1588,6 @@ void FlatpakBackend::checkForUpdates(FlatpakInstallation *installation, FlatpakR
}
FlatpakRefreshAppstreamMetadataJob *job = new FlatpakRefreshAppstreamMetadataJob(installation, remote);
connect(job, &FlatpakRefreshAppstreamMetadataJob::jobRefreshAppstreamMetadataFailed, this, &FlatpakBackend::metadataRefreshed);
connect(job, &FlatpakRefreshAppstreamMetadataJob::jobRefreshAppstreamMetadataFailed, this, &FlatpakBackend::passiveMessage);
connect(job, &FlatpakRefreshAppstreamMetadataJob::jobRefreshAppstreamMetadataFinished, this, &FlatpakBackend::integrateRemote);
connect(job, &FlatpakRefreshAppstreamMetadataJob::finished, this, [this] {
acquireFetching(false);
......
......@@ -49,8 +49,6 @@ void FlatpakRefreshAppstreamMetadataJob::run()
#endif
const QString error = localError ? QString::fromUtf8(localError->message) : QStringLiteral("<no error>");
qWarning() << "Failed to refresh appstream metadata for " << flatpak_remote_get_name(m_remote) << ": " << error;
Q_EMIT jobRefreshAppstreamMetadataFailed(error);
} else {
Q_EMIT jobRefreshAppstreamMetadataFinished(m_installation, m_remote);
}
Q_EMIT jobRefreshAppstreamMetadataFinished(m_installation, m_remote);
}
......@@ -22,7 +22,6 @@ public:
void run() override;
Q_SIGNALS:
void jobRefreshAppstreamMetadataFailed(const QString &errorMessage);
void jobRefreshAppstreamMetadataFinished(FlatpakInstallation *installation, FlatpakRemote *remote);
private:
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment