GitLab

Aleix Pol Gonzalez authored Oct 16, 2021 and Aleix Pol Gonzalez committed Oct 16, 2021

We use it to disable the control if it's not, this way the backend can
support to tell the state but not allow interaction.


(cherry picked from commit 5365c43a)

Aleix Pol Gonzalez authored Oct 15, 2021 and Aleix Pol Gonzalez committed Oct 15, 2021

Instead, we just don't fully load it but we keep it around as we may
have apps from it.


(cherry picked from commit c3f27139)

GIT_SILENT

The tooltip simply repeates the text of this component which is short
enough that it's always visible. It is therefore redundant and
unnecessary.


(cherry picked from commit dce22fc7)

GIT_SILENT

Aleix Pol Gonzalez authored Oct 06, 2021 and Aleix Pol Gonzalez committed Oct 06, 2021

For some (historical) reason we were just showing the branch.

BUG: 443256


(cherry picked from commit 4ba0bc9a)

We had side margins around just the progrss bar, but everything in here
would benefit from them, including the text. So move the margins up to
the parent item to apply them to all the child items.

(cherry picked from commit d63e93dd)

Fushan Wen authored Sep 28, 2021 and Aleix Pol Gonzalez committed Sep 28, 2021

Hovering on the blank area where the package size label is behind will
not trigger tooltips when Discover is still fetching updates.

BUG: 443050


(cherry picked from commit 65cd59c1)

Aleix Pol Gonzalez authored Sep 27, 2021 and Aleix Pol Gonzalez committed Sep 27, 2021

This should make sure we won't be getting any more replies from snapd.

BUG: 425680


(cherry picked from commit 11e72936)

Otherwise we falsely claim the apps's not there (e.g. org.kde.koko)

If we open a flatpakref file for a resource that is in a remote we
already know, just open the application that was requested.

This makes for a much better UX since it gives the full description,
screenshots and reviews.

Delays the use of FlatpakSource::m_remote. Needs more work

BUG: 442709

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Antonio Rojas authored Sep 25, 2021 and Aleix Pol Gonzalez committed Sep 26, 2021

Since PackageKit commit 86f4a2fbf5fcb1230c68a57c4a7bc066aa3f7ef4 the polkit authentication dialog is only shown if the transaction is flagged as interactive

BUG: 442383


(cherry picked from commit 56013c2a)

3bc879cf removed an indirect dependency on widgets, but we use QApplication and QAction so we need to link against widgets

BUG: 442866
(cherry picked from commit a815b7c0)

Aleix Pol Gonzalez authored Sep 23, 2021 and Aleix Pol Gonzalez committed Sep 23, 2021

This is a work-around to 2 half-bugs:
- ListView doesn't really care for models with columns
- QConcatenateTablesProxyModel enforces that we see the minimum amount
of columns available in all of the models.

Empty models (like QStandardItemModel) will report 0 columns if they're
empty. This makes the resulting model to appear bogus to the view.
ListView doesn't seem to refresh the items when a new column is added
because it doesn't care about columns.

Result: this workaround after a bunch of wasted hours. :(

BUG: 442604


(cherry picked from commit 57d8dcd4)

Aleix Pol Gonzalez authored Sep 23, 2021 and Aleix Pol Gonzalez committed Sep 22, 2021

It will either assert or just not work. Not worth it.


(cherry picked from commit 9fd2fb8e)

Aleix Pol Gonzalez authored Sep 21, 2021 and Aleix Pol Gonzalez committed Sep 22, 2021

The report bug action now is brought by Kirigami


(cherry picked from commit 3bc879cf)

Nicolas Fella authored Jun 26, 2021 and Aleix Pol Gonzalez committed Sep 22, 2021

QNetworkAccessManager is enough here, we don't need cookiejar integration and kio-http


(cherry picked from commit 889b2803)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Aleix Pol Gonzalez authored Sep 16, 2021 and Nate Graham committed Sep 16, 2021

It would show the contents de-centered as Breeze's implementation
accounts for the paddings to calculate the contents placing.
Instead just reuse the padding property from button and let the theme do
the right thing.


(cherry picked from commit 1f519711)

GIT_SILENT

Arjen Hiemstra authored Sep 15, 2021 and Nate Graham committed Sep 15, 2021

With the similar support in Kirigami this allows navigating the entire
view as a list.

There's this pattern that is commonly used among most kirigami-based
applications: [searchField, hamburger menu] or [searchField, button]
but there's one (maybe more?) exception to this rule, System Settings,
which uses both a hamburger menu and a button in it's sidebar header
alongside the searchField.

In a recent change done to System Settings the hamburger menu and the
home button position were swapped ([menu, searchField, button] to
[button, searchField, button]) as most kirigami-based applications
tend to put the hamburger menu to the right on their sidebars.

This commit moves the home button to the left so it's consistent with
this pattern.

See: systemsettings!82

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

We can simply override Kirigami.Theme.colorSet; no need for a custom
background recrangle or custom list item colors.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

From: https://invent.kde.org/frameworks/breeze-icons/-/blob/master/icons/apps/48/muondiscover.svg

Felipe Kinoshita authored Jul 12, 2021 and Nate Graham committed Sep 01, 2021

It's now part of the Kirigami.AboutPage component so every application
that uses the about page will have this action automatically.

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This balances out the layout a bit.