1. 16 Oct, 2021 1 commit
  2. 27 Jul, 2021 1 commit
  3. 25 May, 2021 1 commit
  4. 03 May, 2021 1 commit
  5. 19 Feb, 2021 1 commit
  6. 02 Oct, 2020 1 commit
  7. 23 Sep, 2020 2 commits
  8. 14 Sep, 2020 1 commit
    • Arjen Hiemstra's avatar
      Parent dynamically created actions to actionstoolbar in Settings page · c9438fc3
      Arjen Hiemstra authored
      While frameworks/kirigami!95
      fixes the issue that things using ActionToolBar crash when actions
      disappear, it does not fix the underlying issue with actions
      disappearing. This does.
      
      When using createObject(null), a reference to the created object needs
      to be kept, otherwise the object gets destroyed. Unfortunately, passing
      the object to C++ means the JavaScript engine thinks there are no more
      references to the object and it garbage collects the objects. This then
      causes a crash since the toolbar wants to access the action. See also
      https://bugreports.qt.io/browse/QTBUG-25978
      
      To avoid this, parent the created actions to the ActionToolBar so they
      are only deleted when the toolbar is also deleted. Since the actions do
      not change, there is no risk that we end up with a lot of dangling
      actions here.
      c9438fc3
  9. 09 Sep, 2020 1 commit
    • Nate Graham's avatar
      Make all OverlaySheets window-modal · 27a77073
      Nate Graham authored
      Right now half of Discover's OverlaySheets are view-modal and the other
      half are window-modal. This feels arbitrary to the user, and view-modal
      sheets look weird since the global drawer doesn't darken. This is
      because it's still interactive, but there's really no point in being
      able to interact with the global drawer while a sheet is open anyway. So
      let's just make them all window-modal.
      
      BUG: 426065
      FIXED-IN: 5.20
      27a77073
  10. 13 Aug, 2020 1 commit
  11. 02 Jun, 2020 1 commit
  12. 18 May, 2020 1 commit
    • Aleix Pol Gonzalez's avatar
      Hardcode fewer colorSets · aa2e3221
      Aleix Pol Gonzalez authored
      Summary:
      We were overriding them on the background only and it would play weird with the
      feature where the toolbar looks the same as the page.
      
      BUG: 421571
      
      Test Plan: Still feels a bit random that it keeps changing but at least it looks consistent.
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29784
      aa2e3221
  13. 13 May, 2020 1 commit
    • Nate Graham's avatar
      Give all OverlaySheets consistent headers · fb1880d4
      Nate Graham authored
      Summary:
      OverlaySheet has a `header:` property typically used to give the sheet a title. This patch
      used it to give all of Discover's OverlaySheets appropriate titles. The review sheet's
      top layout is slightly adjusted to make this look good.
      
      Test Plan:
      {F8316475}
      {F8316512}
      
      Reviewers: apol, #discover_software_store, #vdg
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29709
      fb1880d4
  14. 28 Mar, 2020 1 commit
  15. 20 Feb, 2020 1 commit
  16. 12 Jan, 2020 1 commit
  17. 31 Dec, 2019 1 commit
  18. 11 Dec, 2019 1 commit
  19. 03 Dec, 2019 1 commit
  20. 07 Nov, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      ui: fix updates page · 93e9f4bd
      Aleix Pol Gonzalez authored
      Looks like something called "display" appeared in the scope and was
      messing up with the whole thing.
      Ugh, looking forward to QML3.
      93e9f4bd
  21. 08 Oct, 2019 2 commits
  22. 18 Sep, 2019 1 commit
  23. 12 Sep, 2019 1 commit
  24. 08 Sep, 2019 1 commit
  25. 18 Mar, 2019 1 commit
  26. 16 Mar, 2019 1 commit
  27. 09 Mar, 2019 1 commit
  28. 27 Feb, 2019 1 commit
  29. 15 Dec, 2018 1 commit
  30. 14 Dec, 2018 2 commits
  31. 03 Dec, 2018 1 commit
  32. 10 Nov, 2018 1 commit
  33. 08 Nov, 2018 1 commit
  34. 06 Nov, 2018 2 commits
  35. 15 Oct, 2018 1 commit
  36. 01 Oct, 2018 1 commit