1. 08 Aug, 2022 1 commit
    • Nate Graham's avatar
      Use correct variable to denote that ResourcesModel is done initializing · 31fd4a4d
      Nate Graham authored
      Due to somewhat confusing variable naming, we were accidentally setting
      m_initializingBackends to false, when that variable actually holds the
      number of backends that are still initializing. Instead we need to set
      m_isInitializing to false.
      
      This fixes a bug where the placeholder message for the MIME type screen
      would fail to appear as expected, because one of the conditions in its
      opacity property was `!ResourcesModel.isInitializing` and that was never
      getting set to false.
      
      BUG: 457528
      FIXED-IN: 5.24.7
      31fd4a4d
  2. 27 Jul, 2022 1 commit
  3. 25 Apr, 2022 1 commit
  4. 21 Feb, 2022 1 commit
  5. 19 Feb, 2022 1 commit
  6. 02 Dec, 2021 1 commit
  7. 24 Nov, 2021 1 commit
  8. 23 Sep, 2021 1 commit
    • Nate Graham's avatar
      Make it easier to file distro bugs · f1bea6c3
      Nate Graham authored and Aleix Pol Gonzalez's avatar Aleix Pol Gonzalez committed
      Discover currently tells users to file bug reports against their distro
      in a few places, but doesn't tell users how to do so, and in any event
      is often is bit cagey about what exactly the error is.
      
      As a result, we still often get bug reports against Discover that are
      distro issues which we can't do anything about. This wastes developer
      and bug triager time in KDE, frustrates users by giving them the
      run-around, and makes Discover look bad in cases where the problem is
      someone else's fault.
      
      This commit attempts to improve that situation by making the error
      messages clearer and also adding a big "Report this issue" button that
      users can click on which will take them to the bug report URL for their
      distro, not for Discover itself.
      
      BUG: 442785
      FIXED-IN: 5.24
      f1bea6c3
  9. 21 May, 2021 1 commit
  10. 13 May, 2021 1 commit
  11. 08 Apr, 2021 1 commit
    • Nate Graham's avatar
      Remove non-useful tooltip while loading updates · 9ce5d98d
      Nate Graham authored and Aleix Pol Gonzalez's avatar Aleix Pol Gonzalez committed
      This tooltip was added to help diagnose issues with stuck backends, but
      has proven troublesome. This commit removes it for the following
      reasons:
      
      1. It did not succeed in fixing the problem in the first place because
         the root cause always seems to be the PackageKit backend being stuck
         for a moment and not issuing updates, so the tooltip doesn't change at
         all or even tell us which backend is stuck.
      2. Due to a bug, the tooltip was always shown when the cursor was
         hovered anywhere over the main panel, so users saw it much more than
         we wanted and filed many bug reports.
      
      This commit partially reverts 2196ed49.
      
      BUG: 432044
      FIXED-IN: 5.21.5
      9ce5d98d
  12. 01 Apr, 2021 1 commit
    • Alexander Lohnau's avatar
      Run clang-format · 67357bfc
      Alexander Lohnau authored
      If you want git blame to ignore formatting revisions run:
      git config blame.ignoreRevsFile .git-blame-ignore-revs
      67357bfc
  13. 08 Feb, 2021 1 commit
  14. 13 Jan, 2021 1 commit
  15. 14 Dec, 2020 2 commits
  16. 10 Dec, 2020 1 commit
  17. 11 Sep, 2020 1 commit
  18. 08 Sep, 2020 1 commit
  19. 21 Jun, 2020 1 commit
  20. 27 Mar, 2020 1 commit
  21. 09 Feb, 2020 1 commit
  22. 07 Feb, 2020 1 commit
  23. 08 Oct, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      Adoption of KUserFeedback for Discover · f1f1597f
      Aleix Pol Gonzalez authored
      Summary:
      Creates components so it can be integrated in any Kirigami application though.
      Haven't tested custom information providers yet, need to get hold of a server
      first to see how it will play out.
      
      Depends on D24010
      Depends on D24011
      
      Reviewers: #plasma, vkrause, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D5961
      f1f1597f
  24. 22 Aug, 2019 1 commit
  25. 15 Jan, 2019 2 commits
    • Dan Leinir Turthra Jensen's avatar
      Ensure only one allInitialised emission · 88e31595
      Dan Leinir Turthra Jensen authored
      To ensure we only have one allInitialized emission (at least just
      one per run of the event handler), swap out the singleshot inline
      timer for a proper QTimer instance. Also, use this timer elsewhere
      the emission was previously done, just in case, and for the sake
      of consistency.
      
      Differential Revision: https://phabricator.kde.org/D18262
      88e31595
    • Dan Leinir Turthra Jensen's avatar
      Fix premature firing of allInitialized signal · 798514c1
      Dan Leinir Turthra Jensen authored
      In case this is in fact the first backend to be added, and also
      happens to be pre-filled, we still need for the rest of the
      backends to be added before trying to send out the initialized
      signal. To ensure this happens, this patch schedules it for the
      start of the next run of the event loop, and ensures that it
      only happens if there are no more backends to initialise.
      
      Specifically, this happens if e.g. the fwupd backend is the
      first to be initialised, and results in (amongst other things)
      that the application loads up and insists that there are no
      application backends.
      
      Differential Revision: https://phabricator.kde.org/D18246
      BUG: 401334
      798514c1
  26. 15 Dec, 2018 1 commit
  27. 17 Oct, 2018 1 commit
  28. 01 Oct, 2018 1 commit
  29. 31 Aug, 2018 1 commit
  30. 19 Jul, 2018 1 commit
  31. 29 Jun, 2018 1 commit
  32. 04 May, 2018 2 commits
  33. 05 Apr, 2018 1 commit
  34. 29 Jan, 2018 1 commit
  35. 11 Jan, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      Improve refresh behavior · 6ea1371c
      Aleix Pol Gonzalez authored
      Implement pull to refresh on the updates view (although it will only work
      on touch screens.
      Make the update action the only one that the ResourcesModel offers and make
      it globally available
      6ea1371c
  36. 10 Jan, 2018 1 commit
  37. 08 Jan, 2018 1 commit