Aleix Pol Gonzalez authored Feb 08, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

When the details are required, they'll be requested. This way we don't
fetch the updatable packages updates when the user just wants to find an
app.

CCBUG: 432657


(cherry picked from commit b9f709b9)

Aleix Pol Gonzalez authored Feb 09, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

Prevent a QString from being created and destroyed every time we call
PackageKitResource::state


(cherry picked from commit dd18487e)

Aleix Pol Gonzalez authored Jan 28, 2021 and Nate Graham committed Jan 28, 2021

We were giving all of them and the proxy isn't smart enough to do the
filtering.

BUG: 428681


(cherry picked from commit c1224ba8)

If the user was gambling his luck by trying to uninstall the "System
Upgrade" entry we create for offline upgrade, now they'll get an error
message rather than a crash.

Just in case we have a different locale than the system's

CCBUG: 424862

No need to build the temporary string if we can compare its parts.

Otherwise we'll be checking an empty list

Should make more readable, less repeated, compact code

Otherwise the list is empty

It should make the resolve calls a bit faster since we are not
processing all packages at startup. It does increase the calls we make
though.

BUG: 423723

If we are still fetching information, delay emission until it's done.
Otherwise we report 0.

Make sure m_appstreamInitialized is already set when we report that the
backend isn't fetching.

Now they're zstd files

BUG: 416283

Summary:
No need to block the backends load on PackageKit appstream usage.

BUG: 409262
BUG: 409599
FIXED-IN: 5.18.0

Test Plan: Tested manually

Reviewers: #discover_software_store, broulik, #plasma

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26547

It's especially faster because it's generated from the glib objects

Summary:
To get rid of tons of logs like :
using... PackageKit::Transaction(0x55db7f249ab0) "/14940_dbaecdcb"
using... PackageKit::Transaction(0x55db7f33fba0) "/14940_dbaecdcb"
using... PackageKit::Transaction(0x55db7d97b860) "/14941_ecaeeebe"

Test Plan: builds

Reviewers: apol, ngraham, mlaurent

Reviewed By: apol, mlaurent

Subscribers: mlaurent, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26533

Centralises decoding of the urls into the same place.
Uses both host and path to get the appstream id, since different people
do it in different ways.

BUG: 408419

Sometimes packages will contain addons to the package itself (e.g. on
archlinux the "gimp" package contains both org.gimp.GIMP and
gimp-data-extras which is an addon to the first).
Don't show the addon when updating like we do when searching.

Aleksei Nikiforov authored Oct 15, 2019 and Aleix Pol Gonzalez committed Oct 15, 2019

Summary:
With latest changes to packagekit, it may now return more packages from 'pkcon get-updates' command with new statuses: "removed" or "obsoleted". This change is needed to filter such packages since Discover is using list of packages similar to the output of mentioned command but ignores package statuses. Otherwise, Discover would try to install all packages, including removed and obsoleted, and fail while trying to resolve such transaction due to package conflicts, if there are such packages present.

packagekit changes:
https://github.com/hughsie/PackageKit/pull/341

Reviewers: jriddell, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24653

Make sure we get a progress bar until all updates have been loaded.
Reduces flickering on PackageKit progressing property by loading
everything as sequentially as possible.

BUG: 412035

Summary: It takes longtime on some distros, so we better show some information about how it's evolving.

Test Plan: Tested on KDE Neon, which is where I've suffered this most

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23324

As we already did for Flatpak.

BUG: 407471

As we already did for Flatpak.

BUG: 407471

Use instead the implementation we have in KCoreAddons

It's common to have appstream components for plugins that some
distributions will split into separate packages. This is useful but it
can easily clutter the UX.
Take Okular for example, it has an appstream component for every format
it supports. On some distributions, like ArchLinux, it will not be
possible to give them separate states as they all point to the same
package. In such case we'll just show the package that is being
extended.

CCBUG: 403118

Dan Leinir Turthra Jensen authored Mar 19, 2019 and Aleix Pol Gonzalez committed Mar 19, 2019

This makes installation of single apps work on openSuse. Previously,
since the source packages has special priority, it was added as the
last item, and it would then get picked for installation, which in
turn would then lead to no functioning application.

Reviewed by Aleix with eyeballs

This makes installation of single apps work on openSuse. Previously,
since the source packages has special priority, it was added as the
last item, and it would then get picked for installation, which in
turn would then lead to no functioning application.

Reviewed by Aleix with eyeballs

Some issues are already quite relevant and could have potentially run
into crashes, like the 3-parameter connects.